Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduces go1.22 to tests (and misc cleanup) #504

Merged
merged 15 commits into from
Feb 8, 2024
Merged

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Feb 7, 2024

Description

  • dapr-bot updated to use go1.22
  • adds go1.22 to the test jobs
  • adds go1.22 to tooling tests
  • removes go1.20 from tests
  • the package as a whole uses go1.21 (examples etc)

Issue reference

None

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

- dapr-bot updated to use go1.22
- adds go1.22 to the test jobs
- adds go1.22 to tooling tests

Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
- retrieve go version from go.mod
- run go mod tidy rather than go get

Signed-off-by: mikeee <hey@mike.ee>
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cefbadb) 70.11% compared to head (07c7672) 61.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
- Coverage   70.11%   61.36%   -8.75%     
==========================================
  Files          35       46      +11     
  Lines        2884     2912      +28     
==========================================
- Hits         2022     1787     -235     
- Misses        748     1010     +262     
- Partials      114      115       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
@mikeee mikeee marked this pull request as ready for review February 8, 2024 15:47
@mikeee mikeee requested a review from a team as a code owner February 8, 2024 15:47
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
@mikeee
Copy link
Member Author

mikeee commented Feb 8, 2024

CC: @JoshVanL @yaron2

@mikeee mikeee changed the title introduces go1.22 to tests introduces go1.22 to tests (and misc cleanup) Feb 8, 2024
Signed-off-by: mikeee <hey@mike.ee>
@yaron2 yaron2 merged commit e45054d into dapr:main Feb 8, 2024
20 of 21 checks passed
@mikeee mikeee deleted the mikeee-go1-22 branch February 8, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants