Skip to content
This repository was archived by the owner on Feb 10, 2025. It is now read-only.

Uncomment some tests #145

Merged
merged 1 commit into from
May 10, 2023
Merged

Uncomment some tests #145

merged 1 commit into from
May 10, 2023

Conversation

natebosch
Copy link
Contributor

These tests had been commented out since the original commit in this
repo even though most of them would pass.

With these tests commented out the suite has an empty group which may
become disallowed.
dart-lang/test#1961

Change double quotes to single quotes.

Skip a test which is currently failing due to an error parsing a float
value with a single digit.

These tests had been commented out since the original commit in this
repo even though most of them would pass.

With these tests commented out the suite has an empty `group` which may
become disallowed.
dart-lang/test#1961

Change double quotes to single quotes.

Skip a test which is currently failing due to an error parsing a float
value with a single digit.
@natebosch natebosch requested a review from jonasfj May 10, 2023 04:26
@kevmoo
Copy link
Contributor

kevmoo commented May 10, 2023

Good find!

Copy link
Contributor

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@jonasfj jonasfj merged commit af3d8cd into master May 10, 2023
@jonasfj jonasfj deleted the uncomment-test branch May 10, 2023 09:46
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 11, 2024
These tests had been commented out since the original commit in this
repo even though most of them would pass.

With these tests commented out the suite has an empty `group` which may
become disallowed.
dart-lang/test#1961

Change double quotes to single quotes.

Skip a test which is currently failing due to an error parsing a float
value with a single digit.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants