Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asset paths for gemini branch #3176

Merged
merged 4 commits into from
Mar 5, 2025

Conversation

johnpryan
Copy link
Contributor

@johnpryan johnpryan commented Mar 4, 2025

This fixes some issues that I found when deploying a preview version of the app to Firebase Hosting:

  • adjusts codemirror path to work in different Firebase Hosting scenarios
  • adjusts the asset configuration to make sure the Gemini logo loads when deployed to Firebase Hosting.

This adjusts the asset configuration to make sure the Gemini logo
loads when deployed to Firebase Hosting.
@johnpryan johnpryan requested a review from devoncarew March 4, 2025 23:20
Copy link

github-actions bot commented Mar 4, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/samples/lib/brick_breaker.dart
pkgs/samples/lib/fibonacci.dart
pkgs/samples/lib/google_ai.dart
pkgs/samples/lib/hello_world.dart
pkgs/samples/lib/main.dart
pkgs/samples/lib/sunflower.dart

@johnpryan johnpryan changed the title Fix gemini asset paths Fix asset paths for gemini branch Mar 4, 2025
@johnpryan johnpryan merged commit 12d8b18 into dart-lang:main Mar 5, 2025
13 checks passed
malloc-error pushed a commit to malloc-error/dart-pad that referenced this pull request Mar 5, 2025
* Fix gemini asset paths

This adjusts the asset configuration to make sure the Gemini logo
loads when deployed to Firebase Hosting.

* Use absolute path for Codemirror

* format

* revert path changes to index.html
@johnpryan johnpryan deleted the fix-gemini-asset-path branch March 6, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants