Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include import information in analyze rpc call #3190

Merged
merged 1 commit into from
Mar 8, 2025
Merged

Conversation

devoncarew
Copy link
Member

  • include import information in analyze rpc call
  • keep as optional in the call for now so that new clients can talk to old servers (for the ~8 min update period)

This does not yet switch appIsFlutter and usesPackageWeb over to this info as we need to decide whether we're just relying on this info or also using the technique of scraping DDC output (hasFlutterWebMarker).


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Mar 7, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/samples/lib/brick_breaker.dart
pkgs/samples/lib/fibonacci.dart
pkgs/samples/lib/google_ai.dart
pkgs/samples/lib/hello_world.dart
pkgs/samples/lib/main.dart
pkgs/samples/lib/sunflower.dart

@devoncarew devoncarew marked this pull request as ready for review March 8, 2025 04:34
@devoncarew
Copy link
Member Author

I may land this now - it'll be useful to have the info populated by prod servers for the client to use.

@devoncarew devoncarew merged commit f90fca8 into main Mar 8, 2025
19 checks passed
@devoncarew devoncarew deleted the imports_info branch March 8, 2025 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants