Format null-aware elements #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move the tests to tall. The old short style formatter doesn't support new syntax and doesn't need to be tested. - Add support for passing experiment flags with tests. The old way of doing this was to just hardcode experiments inside the formatter when a new feature was supported. That made sense when the formatter didn't know about language version, but now that it does, it should probably require experiment flags explicitly and tests for new features should enable them. - Move the code to handle "? into visitMapLiteralEntry(). The AST node does have tokens for "?" and that way there's less special-case code getting threaded through PieceFactory. - Add some tests for comments appearing around "?". (Comments tend to be a tricky corner of the formatter, so we test them heavily.)
|
Thanks for getting this working! I made a handful of changes and pushed a new commit to this PR. I hope that's OK. Let me know what you think and if you're OK with my changes, I'll merge it. |
natebosch
approved these changes
Mar 5, 2025
Thanks for taking a look and updating the PR! The new commit LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for formatting null-aware elements as specified in https://github.com/dart-lang/language/blob/main/accepted/future-releases/0323-null-aware-elements/feature-specification.md.