Upgrade CI SDKs (#1395)

.github/workflows/test-package.yml

@@ -21,7 +21,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        sdk: [3.4.0]
+        sdk: [3.5.0]
     steps:
       - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
       - uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672
@@ -49,8 +49,8 @@ jobs:
         # TODO(sigurdm): our end2end test creates longer filenames than we can
         # handle on windows. See https://github.com/dart-lang/sdk/issues/42416
         os: [ubuntu-latest, macos-latest]
-        sdk: [3.4.3]
-        flutter: [3.22.2]
+        sdk: [3.5.0]
+        flutter: [3.24.0]
     steps:
       - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
       - uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672
@@ -84,7 +84,7 @@ jobs:
       - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
       - uses: dart-lang/setup-dart@0a8a0fc875eb934c15d08629302413c671d3f672
         with:
-          sdk: '3.5.0-307.0.dev' # TODO: switch back to rolling 'dev' channel after it gets updated.
+          sdk: '3.6.0-122.0.dev' # TODO: switch back to rolling 'dev' channel after it gets updated.
       - uses: subosito/flutter-action@44ac965b96f18d999802d4b807e3256d5a3f9fa1
         with:
           # flutter-version: '3.4.0-34.1.pre'

lib/src/tag/tagger.dart

@@ -74,8 +74,7 @@ library;
 
 import 'dart:io';
 
-import 'package:analyzer/dart/analysis/context_builder.dart';
-import 'package:analyzer/dart/analysis/context_locator.dart';
+import 'package:analyzer/dart/analysis/analysis_context_collection.dart';
 import 'package:analyzer/dart/analysis/session.dart';
 import 'package:path/path.dart' as path;
 import 'package:pub_semver/pub_semver.dart';
@@ -128,12 +127,9 @@ class Tagger {
 
   /// Assumes that `dart pub get` has been run.
   factory Tagger(String packageDir) {
-    final session = ContextBuilder()
-        .createContext(
-          contextRoot: ContextLocator().locateRoots(
-            includedPaths: [path.normalize(packageDir)],
-          ).first,
-        )
+    final normalizedPath = path.normalize(packageDir);
+    final session = AnalysisContextCollection(includedPaths: [normalizedPath])
+        .contextFor(normalizedPath)
         .currentSession;
     final pubspecCache = PubspecCache(session);
     final pubspec = pubspecFromDir(packageDir);

test/goldens/end2end/audio_service-0.18.10.json

@@ -171,7 +171,7 @@
         "grantedPoints": 30,
         "maxPoints": 40,
         "status": "failed",
-        "summary": "### [x] 0/10 points: All of the package dependencies are supported in the latest version\n\n|Package|Constraint|Compatible|Latest|\n|:-|:-|:-|:-|\n|[`audio_service_platform_interface`]|`^0.1.0`|0.1.1|0.1.1|\n|[`audio_service_web`]|`^0.1.1`|0.1.2|0.1.2|\n|[`audio_session`]|`^0.1.6+1`|0.1.19|0.1.19|\n|[`clock`]|`^1.1.0`|1.1.1|1.1.1|\n|[`flutter`]|`flutter`|0.0.0|0.0.0|\n|[`flutter_cache_manager`]|`^3.0.1`|3.3.2|3.3.2|\n|[`flutter_web_plugins`]|`flutter`|0.0.0|0.0.0|\n|[`js`]|`^0.6.3`|0.6.7|**0.7.1**|\n|[`rxdart`]|`>=0.26.0 <0.28.0`|0.27.7|0.27.7|\n\n<details><summary>Transitive dependencies</summary>\n\n|Package|Constraint|Compatible|Latest|\n|:-|:-|:-|:-|\n|[`async`]|-|2.11.0|2.11.0|\n|[`characters`]|-|1.3.0|1.3.0|\n|[`collection`]|-|1.18.0|1.18.0|\n|[`crypto`]|-|3.0.3|3.0.3|\n|[`ffi`]|-|2.1.2|2.1.2|\n|[`file`]|-|7.0.0|7.0.0|\n|[`fixnum`]|-|1.1.0|1.1.0|\n|[`http`]|-|1.2.1|1.2.1|\n|[`http_parser`]|-|4.0.2|4.0.2|\n|[`material_color_utilities`]|-|0.8.0|0.11.1|\n|[`meta`]|-|1.12.0|1.15.0|\n|[`path`]|-|1.9.0|1.9.0|\n|[`path_provider`]|-|2.1.3|2.1.3|\n|[`path_provider_android`]|-|2.2.5|2.2.5|\n|[`path_provider_foundation`]|-|2.4.0|2.4.0|\n|[`path_provider_linux`]|-|2.2.1|2.2.1|\n|[`path_provider_platform_interface`]|-|2.1.2|2.1.2|\n|[`path_provider_windows`]|-|2.2.1|2.2.1|\n|[`platform`]|-|3.1.4|3.1.4|\n|[`plugin_platform_interface`]|-|2.1.8|2.1.8|\n|[`sky_engine`]|-|0.0.99|0.0.99|\n|[`source_span`]|-|1.10.0|1.10.0|\n|[`sprintf`]|-|7.0.0|7.0.0|\n|[`sqflite`]|-|2.3.3+1|2.3.3+1|\n|[`sqflite_common`]|-|2.5.4|2.5.4|\n|[`string_scanner`]|-|1.2.0|1.2.0|\n|[`synchronized`]|-|3.1.0+1|3.1.0+1|\n|[`term_glyph`]|-|1.2.1|1.2.1|\n|[`typed_data`]|-|1.3.2|1.3.2|\n|[`uuid`]|-|4.4.0|4.4.0|\n|[`vector_math`]|-|2.1.4|2.1.4|\n|[`web`]|-|0.5.1|0.5.1|\n|[`win32`]|-|5.5.1|5.5.1|\n|[`xdg_directories`]|-|1.0.4|1.0.4|\n</details>\n\nTo reproduce run `dart pub outdated --no-dev-dependencies --up-to-date --no-dependency-overrides`.\n\n[`audio_service_platform_interface`]: https://pub.dev/packages/audio_service_platform_interface\n[`audio_service_web`]: https://pub.dev/packages/audio_service_web\n[`audio_session`]: https://pub.dev/packages/audio_session\n[`clock`]: https://pub.dev/packages/clock\n[`flutter`]: https://pub.dev/packages/flutter\n[`flutter_cache_manager`]: https://pub.dev/packages/flutter_cache_manager\n[`flutter_web_plugins`]: https://pub.dev/packages/flutter_web_plugins\n[`js`]: https://pub.dev/packages/js\n[`rxdart`]: https://pub.dev/packages/rxdart\n[`async`]: https://pub.dev/packages/async\n[`characters`]: https://pub.dev/packages/characters\n[`collection`]: https://pub.dev/packages/collection\n[`crypto`]: https://pub.dev/packages/crypto\n[`ffi`]: https://pub.dev/packages/ffi\n[`file`]: https://pub.dev/packages/file\n[`fixnum`]: https://pub.dev/packages/fixnum\n[`http`]: https://pub.dev/packages/http\n[`http_parser`]: https://pub.dev/packages/http_parser\n[`material_color_utilities`]: https://pub.dev/packages/material_color_utilities\n[`meta`]: https://pub.dev/packages/meta\n[`path`]: https://pub.dev/packages/path\n[`path_provider`]: https://pub.dev/packages/path_provider\n[`path_provider_android`]: https://pub.dev/packages/path_provider_android\n[`path_provider_foundation`]: https://pub.dev/packages/path_provider_foundation\n[`path_provider_linux`]: https://pub.dev/packages/path_provider_linux\n[`path_provider_platform_interface`]: https://pub.dev/packages/path_provider_platform_interface\n[`path_provider_windows`]: https://pub.dev/packages/path_provider_windows\n[`platform`]: https://pub.dev/packages/platform\n[`plugin_platform_interface`]: https://pub.dev/packages/plugin_platform_interface\n[`sky_engine`]: https://pub.dev/packages/sky_engine\n[`source_span`]: https://pub.dev/packages/source_span\n[`sprintf`]: https://pub.dev/packages/sprintf\n[`sqflite`]: https://pub.dev/packages/sqflite\n[`sqflite_common`]: https://pub.dev/packages/sqflite_common\n[`string_scanner`]: https://pub.dev/packages/string_scanner\n[`synchronized`]: https://pub.dev/packages/synchronized\n[`term_glyph`]: https://pub.dev/packages/term_glyph\n[`typed_data`]: https://pub.dev/packages/typed_data\n[`uuid`]: https://pub.dev/packages/uuid\n[`vector_math`]: https://pub.dev/packages/vector_math\n[`web`]: https://pub.dev/packages/web\n[`win32`]: https://pub.dev/packages/win32\n[`xdg_directories`]: https://pub.dev/packages/xdg_directories\n\n<details>\n<summary>\nThe constraint `^0.6.3` on js does not support the stable version `0.7.0`.\n</summary>\n\nTry running `dart pub upgrade --major-versions js` to update the constraint.\n</details>\n\n### [*] 10/10 points: Package supports latest stable Dart and Flutter SDKs\n\n\n### [*] 20/20 points: Compatible with dependency constraint lower bounds\n\n`pub downgrade` does not expose any static analysis error."
+        "summary": "### [x] 0/10 points: All of the package dependencies are supported in the latest version\n\n|Package|Constraint|Compatible|Latest|\n|:-|:-|:-|:-|\n|[`audio_service_platform_interface`]|`^0.1.0`|0.1.1|0.1.1|\n|[`audio_service_web`]|`^0.1.1`|0.1.2|0.1.2|\n|[`audio_session`]|`^0.1.6+1`|0.1.19|0.1.19|\n|[`clock`]|`^1.1.0`|1.1.1|1.1.1|\n|[`flutter`]|`flutter`|0.0.0|0.0.0|\n|[`flutter_cache_manager`]|`^3.0.1`|3.3.2|3.3.2|\n|[`flutter_web_plugins`]|`flutter`|0.0.0|0.0.0|\n|[`js`]|`^0.6.3`|0.6.7|**0.7.1**|\n|[`rxdart`]|`>=0.26.0 <0.28.0`|0.27.7|0.27.7|\n\n<details><summary>Transitive dependencies</summary>\n\n|Package|Constraint|Compatible|Latest|\n|:-|:-|:-|:-|\n|[`async`]|-|2.11.0|2.11.0|\n|[`characters`]|-|1.3.0|1.3.0|\n|[`collection`]|-|1.18.0|1.18.0|\n|[`crypto`]|-|3.0.3|3.0.3|\n|[`ffi`]|-|2.1.2|2.1.2|\n|[`file`]|-|7.0.0|7.0.0|\n|[`fixnum`]|-|1.1.0|1.1.0|\n|[`http`]|-|1.2.1|1.2.1|\n|[`http_parser`]|-|4.0.2|4.0.2|\n|[`material_color_utilities`]|-|0.11.1|0.11.1|\n|[`meta`]|-|1.15.0|1.15.0|\n|[`path`]|-|1.9.0|1.9.0|\n|[`path_provider`]|-|2.1.3|2.1.3|\n|[`path_provider_android`]|-|2.2.5|2.2.5|\n|[`path_provider_foundation`]|-|2.4.0|2.4.0|\n|[`path_provider_linux`]|-|2.2.1|2.2.1|\n|[`path_provider_platform_interface`]|-|2.1.2|2.1.2|\n|[`path_provider_windows`]|-|2.2.1|2.2.1|\n|[`platform`]|-|3.1.4|3.1.4|\n|[`plugin_platform_interface`]|-|2.1.8|2.1.8|\n|[`sky_engine`]|-|0.0.99|0.0.99|\n|[`source_span`]|-|1.10.0|1.10.0|\n|[`sprintf`]|-|7.0.0|7.0.0|\n|[`sqflite`]|-|2.3.3+1|2.3.3+1|\n|[`sqflite_common`]|-|2.5.4|2.5.4|\n|[`string_scanner`]|-|1.2.0|1.2.0|\n|[`synchronized`]|-|3.1.0+1|3.1.0+1|\n|[`term_glyph`]|-|1.2.1|1.2.1|\n|[`typed_data`]|-|1.3.2|1.3.2|\n|[`uuid`]|-|4.4.0|4.4.0|\n|[`vector_math`]|-|2.1.4|2.1.4|\n|[`web`]|-|0.5.1|0.5.1|\n|[`win32`]|-|5.5.1|5.5.1|\n|[`xdg_directories`]|-|1.0.4|1.0.4|\n</details>\n\nTo reproduce run `dart pub outdated --no-dev-dependencies --up-to-date --no-dependency-overrides`.\n\n[`audio_service_platform_interface`]: https://pub.dev/packages/audio_service_platform_interface\n[`audio_service_web`]: https://pub.dev/packages/audio_service_web\n[`audio_session`]: https://pub.dev/packages/audio_session\n[`clock`]: https://pub.dev/packages/clock\n[`flutter`]: https://pub.dev/packages/flutter\n[`flutter_cache_manager`]: https://pub.dev/packages/flutter_cache_manager\n[`flutter_web_plugins`]: https://pub.dev/packages/flutter_web_plugins\n[`js`]: https://pub.dev/packages/js\n[`rxdart`]: https://pub.dev/packages/rxdart\n[`async`]: https://pub.dev/packages/async\n[`characters`]: https://pub.dev/packages/characters\n[`collection`]: https://pub.dev/packages/collection\n[`crypto`]: https://pub.dev/packages/crypto\n[`ffi`]: https://pub.dev/packages/ffi\n[`file`]: https://pub.dev/packages/file\n[`fixnum`]: https://pub.dev/packages/fixnum\n[`http`]: https://pub.dev/packages/http\n[`http_parser`]: https://pub.dev/packages/http_parser\n[`material_color_utilities`]: https://pub.dev/packages/material_color_utilities\n[`meta`]: https://pub.dev/packages/meta\n[`path`]: https://pub.dev/packages/path\n[`path_provider`]: https://pub.dev/packages/path_provider\n[`path_provider_android`]: https://pub.dev/packages/path_provider_android\n[`path_provider_foundation`]: https://pub.dev/packages/path_provider_foundation\n[`path_provider_linux`]: https://pub.dev/packages/path_provider_linux\n[`path_provider_platform_interface`]: https://pub.dev/packages/path_provider_platform_interface\n[`path_provider_windows`]: https://pub.dev/packages/path_provider_windows\n[`platform`]: https://pub.dev/packages/platform\n[`plugin_platform_interface`]: https://pub.dev/packages/plugin_platform_interface\n[`sky_engine`]: https://pub.dev/packages/sky_engine\n[`source_span`]: https://pub.dev/packages/source_span\n[`sprintf`]: https://pub.dev/packages/sprintf\n[`sqflite`]: https://pub.dev/packages/sqflite\n[`sqflite_common`]: https://pub.dev/packages/sqflite_common\n[`string_scanner`]: https://pub.dev/packages/string_scanner\n[`synchronized`]: https://pub.dev/packages/synchronized\n[`term_glyph`]: https://pub.dev/packages/term_glyph\n[`typed_data`]: https://pub.dev/packages/typed_data\n[`uuid`]: https://pub.dev/packages/uuid\n[`vector_math`]: https://pub.dev/packages/vector_math\n[`web`]: https://pub.dev/packages/web\n[`win32`]: https://pub.dev/packages/win32\n[`xdg_directories`]: https://pub.dev/packages/xdg_directories\n\n<details>\n<summary>\nThe constraint `^0.6.3` on js does not support the stable version `0.7.0`.\n</summary>\n\nTry running `dart pub upgrade --major-versions js` to update the constraint.\n</details>\n\n### [*] 10/10 points: Package supports latest stable Dart and Flutter SDKs\n\n\n### [*] 20/20 points: Compatible with dependency constraint lower bounds\n\n`pub downgrade` does not expose any static analysis error."
       }
     ]
   },

test/goldens/end2end/audio_service-0.18.10.json_report.md

@@ -95,8 +95,8 @@ Because:
 |[`fixnum`]|-|1.1.0|1.1.0|
 |[`http`]|-|1.2.1|1.2.1|
 |[`http_parser`]|-|4.0.2|4.0.2|
-|[`material_color_utilities`]|-|0.8.0|0.11.1|
-|[`meta`]|-|1.12.0|1.15.0|
+|[`material_color_utilities`]|-|0.11.1|0.11.1|
+|[`meta`]|-|1.15.0|1.15.0|
 |[`path`]|-|1.9.0|1.9.0|
 |[`path_provider`]|-|2.1.3|2.1.3|
 |[`path_provider_android`]|-|2.2.5|2.2.5|

test/goldens/end2end/bulma_min-0.7.4.json

@@ -74,7 +74,7 @@
         "grantedPoints": 0,
         "maxPoints": 40,
         "status": "failed",
-        "summary": "### [x] 0/10 points: All of the package dependencies are supported in the latest version\n\n<details>\n<summary>\nSdk constraint doesn't support current Dart version {{sdk-version}}. Cannot run `dart pub outdated`.\n</summary>\n\n`pubspec.yaml:8:8`\n\n```\n  ╷\n8 │   sdk: '>=1.0.0 <3.0.0'\n  │        ^^^^^^^^^^^^^^^^\n  ╵\n```\n\n</details>\n\n### [x] 0/10 points: Package supports latest stable Dart and Flutter SDKs\n\n<details>\n<summary>\nSdk constraint doesn't support current Dart version {{sdk-version}}.\n</summary>\n\n`pubspec.yaml:8:8`\n\n```\n  ╷\n8 │   sdk: '>=1.0.0 <3.0.0'\n  │        ^^^^^^^^^^^^^^^^\n  ╵\n```\n\nTry widening the upper boundary of the constraint.\n</details>\n\n### [x] 0/20 points: Compatible with dependency constraint lower bounds\n\n`dart pub downgrade` failed with:\n\n```\nOUT:\nResolving dependencies...\nERR:\nThe lower bound of \"sdk: '>=1.0.0 <3.0.0'\" must be 2.12.0'\nor higher to enable null safety.\n\nThe current Dart SDK (3.4.3) only supports null safety.\n\nFor details, see https://dart.dev/null-safety\n```\n\nRun `dart pub downgrade` and then `dart analyze` to reproduce the above problem.\n\nYou may run `dart pub upgrade --tighten` to update your dependency constraints, see [dart.dev/go/downgrade-testing](https://dart.dev/go/downgrade-testing) for details."
+        "summary": "### [x] 0/10 points: All of the package dependencies are supported in the latest version\n\n<details>\n<summary>\nSdk constraint doesn't support current Dart version {{sdk-version}}. Cannot run `dart pub outdated`.\n</summary>\n\n`pubspec.yaml:8:8`\n\n```\n  ╷\n8 │   sdk: '>=1.0.0 <3.0.0'\n  │        ^^^^^^^^^^^^^^^^\n  ╵\n```\n\n</details>\n\n### [x] 0/10 points: Package supports latest stable Dart and Flutter SDKs\n\n<details>\n<summary>\nSdk constraint doesn't support current Dart version {{sdk-version}}.\n</summary>\n\n`pubspec.yaml:8:8`\n\n```\n  ╷\n8 │   sdk: '>=1.0.0 <3.0.0'\n  │        ^^^^^^^^^^^^^^^^\n  ╵\n```\n\nTry widening the upper boundary of the constraint.\n</details>\n\n### [x] 0/20 points: Compatible with dependency constraint lower bounds\n\n`dart pub downgrade` failed with:\n\n```\nOUT:\nResolving dependencies...\nERR:\nThe lower bound of \"sdk: '>=1.0.0 <3.0.0'\" must be 2.12.0'\nor higher to enable null safety.\n\nThe current Dart SDK (3.5.0) only supports null safety.\n\nFor details, see https://dart.dev/null-safety\n```\n\nRun `dart pub downgrade` and then `dart analyze` to reproduce the above problem.\n\nYou may run `dart pub upgrade --tighten` to update your dependency constraints, see [dart.dev/go/downgrade-testing](https://dart.dev/go/downgrade-testing) for details."
       }
     ]
   },

test/goldens/end2end/bulma_min-0.7.4.json_report.md

@@ -99,7 +99,7 @@ ERR:
 The lower bound of "sdk: '>=1.0.0 <3.0.0'" must be 2.12.0'
 or higher to enable null safety.
 
-The current Dart SDK (3.4.3) only supports null safety.
+The current Dart SDK (3.5.0) only supports null safety.
 
 For details, see https://dart.dev/null-safety
 ```

test/goldens/end2end/mime_type-0.3.2.json

@@ -67,7 +67,7 @@
         "grantedPoints": 0,
         "maxPoints": 40,
         "status": "failed",
-        "summary": "### [x] 0/10 points: All of the package dependencies are supported in the latest version\n\n<details>\n<summary>\nSdk constraint doesn't support current Dart version {{sdk-version}}. Cannot run `dart pub outdated`.\n</summary>\n\n`pubspec.yaml:10:10`\n\n```\n   ╷\n10 │     sdk: '>=0.8.10 <3.0.0'\n   │          ^^^^^^^^^^^^^^^^^\n   ╵\n```\n\n</details>\n\n### [x] 0/10 points: Package supports latest stable Dart and Flutter SDKs\n\n<details>\n<summary>\nSdk constraint doesn't support current Dart version {{sdk-version}}.\n</summary>\n\n`pubspec.yaml:10:10`\n\n```\n   ╷\n10 │     sdk: '>=0.8.10 <3.0.0'\n   │          ^^^^^^^^^^^^^^^^^\n   ╵\n```\n\nTry widening the upper boundary of the constraint.\n</details>\n\n### [x] 0/20 points: Compatible with dependency constraint lower bounds\n\n`dart pub downgrade` failed with:\n\n```\nOUT:\nResolving dependencies...\nERR:\nThe lower bound of \"sdk: '>=0.8.10 <3.0.0'\" must be 2.12.0'\nor higher to enable null safety.\n\nThe current Dart SDK (3.4.3) only supports null safety.\n\nFor details, see https://dart.dev/null-safety\n```\n\nRun `dart pub downgrade` and then `dart analyze` to reproduce the above problem.\n\nYou may run `dart pub upgrade --tighten` to update your dependency constraints, see [dart.dev/go/downgrade-testing](https://dart.dev/go/downgrade-testing) for details."
+        "summary": "### [x] 0/10 points: All of the package dependencies are supported in the latest version\n\n<details>\n<summary>\nSdk constraint doesn't support current Dart version {{sdk-version}}. Cannot run `dart pub outdated`.\n</summary>\n\n`pubspec.yaml:10:10`\n\n```\n   ╷\n10 │     sdk: '>=0.8.10 <3.0.0'\n   │          ^^^^^^^^^^^^^^^^^\n   ╵\n```\n\n</details>\n\n### [x] 0/10 points: Package supports latest stable Dart and Flutter SDKs\n\n<details>\n<summary>\nSdk constraint doesn't support current Dart version {{sdk-version}}.\n</summary>\n\n`pubspec.yaml:10:10`\n\n```\n   ╷\n10 │     sdk: '>=0.8.10 <3.0.0'\n   │          ^^^^^^^^^^^^^^^^^\n   ╵\n```\n\nTry widening the upper boundary of the constraint.\n</details>\n\n### [x] 0/20 points: Compatible with dependency constraint lower bounds\n\n`dart pub downgrade` failed with:\n\n```\nOUT:\nResolving dependencies...\nERR:\nThe lower bound of \"sdk: '>=0.8.10 <3.0.0'\" must be 2.12.0'\nor higher to enable null safety.\n\nThe current Dart SDK (3.5.0) only supports null safety.\n\nFor details, see https://dart.dev/null-safety\n```\n\nRun `dart pub downgrade` and then `dart analyze` to reproduce the above problem.\n\nYou may run `dart pub upgrade --tighten` to update your dependency constraints, see [dart.dev/go/downgrade-testing](https://dart.dev/go/downgrade-testing) for details."
       }
     ]
   },

test/goldens/end2end/mime_type-0.3.2.json_report.md

@@ -128,7 +128,7 @@ ERR:
 The lower bound of "sdk: '>=0.8.10 <3.0.0'" must be 2.12.0'
 or higher to enable null safety.
 
-The current Dart SDK (3.4.3) only supports null safety.
+The current Dart SDK (3.5.0) only supports null safety.
 
 For details, see https://dart.dev/null-safety
 ```