-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update isolates.md - TODOs are reversed #5500
Conversation
Todo comments were reversed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching!
Looks like some tests are not going through? This change shouldn't have affected anything though, or could it? Anything that I can do? Edit - my bad, I read the contributor guide but still missed it - pipeline should go through now |
/gcbrun |
@dkbast : Thanks for your contribution! I'm running the tests now and staging the site. This should be merged in the next hour. |
Visit the preview URL for this PR (updated for commit eda709f): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this Damian!
And thanks Eric for the review :)
Fixes confusing (because reversed) Todo comments in the mini exercise.
Fixes confusing (because reversed) Todo comments in the mini exercise.
Fixes confusing (because reversed) Todo comments in the mini exercise.
Contribution guidelines:
dart format
.<?code-excerpt
need to be updated in their source.dart
file as well.