Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isolates.md - TODOs are reversed #5500

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Conversation

dkbast
Copy link
Contributor

@dkbast dkbast commented Feb 1, 2024

Fixes confusing (because reversed) Todo comments in the mini exercise.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • This PR doesn’t contain automatically generated corrections or text (Grammarly, LLMs, and similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Code changes should generally follow the Dart style guide and use dart format.
  • Updates to code excerpts indicated by <?code-excerpt need to be updated in their source .dart file as well.

Todo comments were reversed
@parlough parlough requested a review from ericwindmill February 1, 2024 16:28
Copy link
Contributor

@ericwindmill ericwindmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching!

@dkbast
Copy link
Contributor Author

dkbast commented Feb 2, 2024

Looks like some tests are not going through? This change shouldn't have affected anything though, or could it?

Anything that I can do?

Edit - my bad, I read the contributor guide but still missed it - pipeline should go through now

@atsansone
Copy link
Contributor

/gcbrun

@atsansone
Copy link
Contributor

@dkbast : Thanks for your contribution! I'm running the tests now and staging the site. This should be merged in the next hour.

@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit eda709f):

https://dart-dev--pr5500-patch-4-vpt9kumq.web.app

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this Damian!

And thanks Eric for the review :)

@parlough parlough merged commit 779e378 into dart-lang:main Feb 2, 2024
8 checks passed
atsansone pushed a commit to atsansone/site-www that referenced this pull request Feb 9, 2024
Fixes confusing (because reversed) Todo comments in the mini exercise.
atsansone pushed a commit to atsansone/site-www that referenced this pull request Feb 20, 2024
Fixes confusing (because reversed) Todo comments in the mini exercise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants