Change effective dart rule about line length #6404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 0b1f876): |
munificent
approved these changes
Feb 10, 2025
src/content/effective-dart/style.md
Outdated
|
|
||
| ### AVOID lines longer than 80 characters | ||
| <a id="avoid-lines-longer-than-80-characters"></a> | ||
| ### PREFER lines 80 characters or less |
There was a problem hiding this comment.
Phew, good thing I'm not a technical writer or something 😅
src/content/effective-dart/style.md
Outdated
| @@ -469,7 +469,8 @@ compact. The main offender is usually `VeryLongCamelCaseClassNames`. Ask | |||
| yourself, "Does each word in that type name tell me something critical or | |||
| prevent a name collision?" If not, consider omitting it. | |||
|
|
|||
| Note that `dart format` does 99% of this for you, but the last 1% is you. | |||
| Note that `dart format` defaults to 80 characters or less, though you can | |||
parlough
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Great update, thanks @MaryaBelanger! :D
Do apply Bob's "or fewer" fix though :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6142