Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the pubspec_overrides.yaml file #6462

Merged
merged 12 commits into from
Feb 28, 2025
Merged

Document the pubspec_overrides.yaml file #6462

merged 12 commits into from
Feb 28, 2025

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Feb 27, 2025

fixes #5019

@sigurdm sigurdm requested review from jonasfj and parlough February 27, 2025 09:09
@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Feb 27, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit aa488ea):

https://dart-dev--pr6462-document-pubspec-overrides-yaml-ydxs916m.web.app

jonasfj
jonasfj approved these changes Feb 27, 2025
View reviewed changes
sigurdm and others added 3 commits February 27, 2025 13:39
@sigurdm @jonasfj
Update src/content/tools/pub/dependencies.md
49b112a 
Co-authored-by: Jonas Finnemann Jensen <jonasfj@google.com>
@sigurdm @jonasfj
Update src/content/tools/pub/dependencies.md
dd2c1a4 
Co-authored-by: Jonas Finnemann Jensen <jonasfj@google.com>
@sigurdm @jonasfj
Update src/content/tools/pub/package-layout.md
65ca958 
Co-authored-by: Jonas Finnemann Jensen <jonasfj@google.com>
parlough
parlough reviewed Feb 28, 2025
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me, thanks so much for tackling this @sigurdm! I appreciate you adding it to the layout index as well.

I do have two minor wording suggestions to consider and a question about the file's introduction:

@parlough parlough changed the title Document pubspec_overrides.yaml file Document the pubspec_overrides.yaml file Feb 28, 2025
parlough
parlough approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those updates! Looks good to me :)

I pushed a commit with some minor formatting and copy changes as well as added a redirect from dart.dev/to/pubspec-overrides to the new section :)

@parlough parlough merged commit d641ec3 into main Feb 28, 2025
10 checks passed
@parlough parlough deleted the document_pubspec_overrides_yaml branch February 28, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasfj jonasfj jonasfj approved these changes

@parlough parlough parlough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add details on pubspec_overrides.yaml to 'Package dependencies' page
4 participants
@sigurdm @dart-github-bot @jonasfj @parlough