-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[package_config] Fix incorrect error message when validating parameters in LanguageVersion.new
#2017
[package_config] Fix incorrect error message when validating parameters in LanguageVersion.new
#2017
Conversation
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch!
@kevmoo Thanks for taking a look! I don't have commit access on this repo if you'd mind committing or assigning another reviewer to do so. Thanks! |
Revisions updated by `dart tools/rev_sdk_deps.dart`. http (https://github.com/dart-lang/http/compare/e28f9f5..900da9f): 900da9f 2025-02-13 Simon Binder Fix browser clients in workers (dart-lang/http#1715) i18n (https://github.com/dart-lang/i18n/compare/189c228..06a664f): 06a664f 2025-02-18 Moritz Remove `package:js` dependency (dart-lang/i18n#946) tools (https://github.com/dart-lang/tools/compare/750b4ad..b51f39d): b51f39d0 2025-02-18 Parker Lougheed [package_config] Fix incorrect error message when validating parameters in `LanguageVersion.new` (dart-lang/tools#2017) Change-Id: I8ff7b42069d8a979107f3f68449fa2614db8c9c9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410561 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
No description provided.