Skip to content

Commit

Permalink
RELEASE 6.6.3
Browse files Browse the repository at this point in the history
  • Loading branch information
dascritch committed Feb 23, 2021
1 parent 559341a commit 0336c6f
Show file tree
Hide file tree
Showing 7 changed files with 25 additions and 42 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Some links :
* [How to cite a podcast](https://www.buzzsprout.com/blog/cite-podcast), now you can support time positions URL
* Main author : [Xavier "dascritch" Mouton-Dubosc](http://dascritch.com)

Version : 6.7pre. [Licence GPL 3](LICENSE)
Version : 6.6.3 [Licence GPL 3](LICENSE)

Purpose
-------
Expand Down
38 changes: 11 additions & 27 deletions RELEASE.md
Original file line number Diff line number Diff line change
@@ -1,30 +1,5 @@
RELEASE NOTES version 6.7pre
============================

New features
------------

* not yet

Corrections
-----------

* Lot of corrections in chapters panels/tracks due to surprising behaviour of Chrome :
* multiple TextTracks.activeCues creating race conflicts but only in some specific conditions,
* chapter tracks not displayed if duration not seen in time, refreshing timeline when duration is certainly known,
* unuseful refreshes
* Removed Chapter editor from github pages due to a sync problem. Now available [as a standalone and not yet skinned page](applications/chapters_editor.html) with better explanations
* An `applications` sub-directory is created by the way

Back-end
--------

* Mask error from Google Closure that doesn't `recognize string.replace().replaceAll()`
* Primitives for package github ([#86](#86)). “to be done”


RELEASE NOTES version 6.6.2
============================
RELEASE NOTES version 6.6.3
===========================

New features
------------
Expand Down Expand Up @@ -53,6 +28,12 @@ Corrections
* We try to preload duration metadata when the mouse cursors goes over the timeline on a not know duration and not streamed source ([#88](#88))
* github-pages trigger strange problems, numerous CPU-audio instances
* Chrome returned more than one activeCue, strange regression
* Lot of corrections in chapters panels/tracks due to surprising behaviour of Chrome :
* multiple TextTracks.activeCues creating race conflicts but only in some specific conditions,
* chapter tracks not displayed if duration not seen in time, refreshing timeline when duration is certainly known,
* unuseful refreshes
* Removed Chapter editor from github pages due to a sync problem. Now available [as a standalone and not yet skinned page](applications/chapters_editor.html) with better explanations


Back-end
--------
Expand All @@ -66,8 +47,11 @@ Back-end
* Erroneous `@brief` annotations changed to `@summary`
* … but a lot of bugs in Closure, as TextTracks objects aren't declared as iterable, a surprising “*Property replaceAll never defined on String*” and so on…
* We have a [surprising bug in Chrome that avoid to use `audiotag.currentTime=<number>` ONLY if the source is hosted on localhost](https://stackoverflow.com/questions/52620284/make-html5-video-start-at-specified-currenttime-in-chrome), if your local server doesn't support HTTP response 206 (partial content). If you need to local test on Chrome, please user file:/// protocol or a complete web server.
* An `applications` sub-directory is created by the way
* Mask error from Google Closure that doesn't `recognize string.replace().replaceAll()`
* Primitives for package github ([#86](#86)). “to be done”


Making of
=========

Expand Down
12 changes: 6 additions & 6 deletions dist/cpu-audio.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/cpu-audio.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cpu-audio",
"version": "6.7.0",
"version": "6.6.3",
"description": "An audio WebComponent to provide an user-interface, timecoded links and some other features to an <audio> tag",
"main": "index.js",
"directories": {
Expand Down
9 changes: 4 additions & 5 deletions src/45_element_cpu.js
Original file line number Diff line number Diff line change
Expand Up @@ -1404,7 +1404,7 @@ class CPU_element_api {
*
* @param {Object|undefined} event The event
*/
build_chapters(event = undefined) {
async build_chapters(event = undefined) {
// this functions is called THREE times at load : at build, at loadedmetada event and at load event
// and afterwards, we have to reposition track points on duractionchange

Expand Down Expand Up @@ -1500,20 +1500,19 @@ class CPU_element_api {
* @private
*/
build_chapters_loader() {

this.audiotag.addEventListener('durationchange', this.reposition_tracks.bind(this), passive_ev);
this.build_chapters();
let this_build_chapters = this.build_chapters.bind(this);
// sometimes, we MAY have loose loading

this.audiotag.addEventListener('loadedmetadata', this_build_chapters, once_passive_ev);


let track_element = this.audiotag.querySelector('track[kind="chapters"]');
if ((track_element) && (!track_element._CPU_load_ev)) {
track_element._CPU_load_ev = track_element.addEventListener('load', this_build_chapters, passive_ev);
}

// stupidly, we need to try to catch its evend load twice, and even redraw the track element if the total audio duration is known after drawing it
this.reposition_tracks();
this.audiotag.addEventListener('durationchange', this.reposition_tracks.bind(this), passive_ev);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/license.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/** @license
Cpu-Audio: an extension to the hash system to address timecode into audio/video elements.
Version 6.7pre
Version 6.6.3
Copyright (C) 2014-2021 Xavier "dascritch" Mouton-Dubosc & contributors.
License GNU GPL 3

Expand Down

0 comments on commit 0336c6f

Please sign in to comment.