Add a couple of tests for bundle init with custom template #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
requested review from
pietern,
andrewnester and
shreyas-goenka
as code owners
shreyas-goenka
approved these changes
Feb 7, 2025
| @@ -0,0 +1,2 @@ | |||
| errcode trace $CLI bundle init . | |||
| # test runner will complain if helpers.txt is found - it should not be there | |||
There was a problem hiding this comment.
What does this comment refer to? I don't follow.
There was a problem hiding this comment.
Good catch, that was a copy paste error. Cleaned up.
helpers - tests user_name helper with default local server helpers-error - tests user_name helper if API response had error
denik
force-pushed
the
denik/bundle-init-helper-tests
branch
from
4b0d05c to
797ff12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These test custom template and what happens if helper function returns an error.