Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS for cmd/labs #2295

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Update CODEOWNERS for cmd/labs #2295

merged 1 commit into from
Feb 4, 2025

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Feb 4, 2025

Changes

The CODEOWNERS file must live in one of the directories specified in the docs, so the existing file under cmd/labs didn't work. This change moves the contents to the top-level file and includes @alexott as owner.

@pietern
Copy link
Contributor Author

pietern commented Feb 4, 2025

There is a check that says, "This CODEOWNERS file contains errors." I'd like to see what happens if we merge as is.

@pietern pietern added this pull request to the merge queue Feb 4, 2025
@shreyas-goenka
Copy link
Contributor

shreyas-goenka commented Feb 4, 2025

@pietern Seems like we need to add Alex and Serge to writers for the repo here: https://github.com/databricks/cli/settings/access

Otherwise, they seem to not be registered as "collaborators" by the repo.

Merged via the queue into main with commit 2e14558 Feb 4, 2025
9 checks passed
@pietern pietern deleted the codeowners branch February 4, 2025 21:24
@shreyas-goenka
Copy link
Contributor

I've gone ahead and given @alexott and @nfx write permissions on the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants