Fix minor test bug for WPM #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benc-db
requested review from
andrefurlan-db,
susodapop and
rcypher-databricks
as code owners
rcypher-databricks
previously approved these changes
Dec 7, 2023
| msg = res.results[0].message | ||
| assert "Compute resource alternate_warehouse does not exist" in msg | ||
| assert model_name in msg | ||
|
|
||
|
|
||
| @pytest.mark.skip("May fail non-deterministically due to issue in dbt test framework.") |
There was a problem hiding this comment.
Shouldn't we be disable TestWarehousePerModel and leaving these ones to run. I though we should be disabling the tests that use the profiles_config_update fixture.
There was a problem hiding this comment.
I feel like it's more valuable to validate the affirmative case, and even with the bug we identified, these additions to the profile shouldn't impact any other tests (since their schema's won't reference the compute block)
There was a problem hiding this comment.
Discussed out of band. If we can't rely on read ordering, we can't guarantee this will read what it writes, so safer to keep the ones that don't need to write.
rcypher-databricks
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes minor test log bugs for WPM and long sessions.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.