Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Materialized View Config Level Up #536

Merged
merged 35 commits into from
Jan 25, 2024
Merged

Materialized View Config Level Up #536

merged 35 commits into from
Jan 25, 2024

Conversation

benc-db
Copy link
Collaborator

@benc-db benc-db commented Dec 18, 2023 •
edited
Loading

Description

Completes support of on_config_changes for MVs, expanding the config that we support. Trying to decide how to clean up tblproperties, because it turns out they're not alterable for MVs, but are for other materializations. Also, might try to move to_sql stuff out to macros if I come up with a comparably clean way to call and test there, as Mike convinced me that we should delegate to jinja as our presentation layer.

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.

@benc-db
Copy link
Collaborator Author

benc-db commented Dec 18, 2023

@mikealfare

@benc-db benc-db marked this pull request as draft December 18, 2023 23:41
@benc-db benc-db merged commit baaf1fb into main Jan 25, 2024
21 checks passed
benc-db added a commit that referenced this pull request Feb 21, 2024
@benc-db
Revert "Materialized View Config Level Up (#536)"
eb29b03 
This reverts commit baaf1fb, reversing
changes made to e7efe5d.

# Conflicts:
#	CHANGELOG.md
benc-db added a commit that referenced this pull request Feb 22, 2024
@benc-db
Revert "Materialized View Config Level Up (#536)" (#591)
82c5dd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcypher-databricks rcypher-databricks rcypher-databricks left review comments

@andrefurlan-db andrefurlan-db Awaiting requested review from andrefurlan-db andrefurlan-db is a code owner

@susodapop susodapop Awaiting requested review from susodapop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benc-db @rcypher-databricks