Updated tests that were modifying the dbt profile #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in the dbt testing infrastructure: "[CT-3478] [Bug] Editing profiles as part of tests is not thread-safe #9254" dbt-labs/dbt-core#9254 This causes issues for tests that use the profiles_config_update fixture. Added class level fixture dbt_profile_data to conftest.py. This creates the profile used by all the tests, in it additional targets are added to be used by the tests that were formerly using profiles_config_update. Updated the tests to remove the profiles_config_update fixture and to specify the appropriate target when running. Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
rcypher-databricks
requested review from
andrefurlan-db,
susodapop and
benc-db
as code owners
|
Approved, but please open on databricks fork so that we can run the integration/functional tests. |
|
I'm going to pull and push this to our main fork to run the tests |
benc-db
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a bug in the dbt testing infrastructure:
"[CT-3478] [Bug] Editing profiles as part of tests is not thread-safe #9254"
dbt-labs/dbt-core#9254
This causes issues for tests that use the profiles_config_update fixture.
Added class level fixture dbt_profile_data to conftest.py.
This creates the profile used by all the tests, in it additional targets are added to be used by the tests that were formerly using profiles_config_update.
Updated the tests to remove the profiles_config_update fixture and to specify the appropriate target when running.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.