[PECO-1387] mv/st: Fix typo in #555 #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
susodapop
requested review from
andrefurlan-db,
benc-db and
rcypher-databricks
as code owners
benc-db
approved these changes
Jan 18, 2024
rcypher-databricks
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to #555 to fix a typo in
connections.py. I have confirmed that this PR now passes theTestMaterializedViewtests. The value ofself._cursor.connection.thrift_backend._auth_provider._header_factoryis a callable which is instantiated byBearerAuthand returns a dictionary. So we don't need to call it fromconnections.py.No addition to the changelog since the previous PR hasn't been released yet.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.