Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Custom DC] [Terraform] Allow data management job to connect to Redis #4925

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Custom DC] [Terraform] Allow data management job to connect to Redis #4925

wants to merge 4 commits into from
+74 −68

Conversation

hqpho
Copy link
Contributor

@hqpho hqpho commented Feb 3, 2025 •
edited
Loading

Once datacommonsorg/import#364 is merged (and import submod is updated), Redis will be cleared whenever data is reloaded.

Also:

  • Clean up a TODO about using stable instead of latest data management image
  • Remove unused VPC connector config
  • Format edited *.tf files (hide whitespace changes in diffs for easier reviewing)

@hqpho hqpho changed the title [Custom DC] [Terraform] Make REDIS_HOST and REDIS_PORT available to the data management container [Custom DC] [Terraform] Allow data management job to connect to Redis Feb 4, 2025
@hqpho hqpho marked this pull request as ready for review February 4, 2025 18:13
@hqpho hqpho requested review from dwnoble and keyurva February 4, 2025 18:13
@hqpho hqpho mentioned this pull request Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwnoble dwnoble Awaiting requested review from dwnoble

@keyurva keyurva Awaiting requested review from keyurva

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hqpho