-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(lineage) Support views and sorting in impact analysis (#12769)
- Loading branch information
1 parent
3f6b8c1
commit 17de393
Showing
7 changed files
with
389 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
130 changes: 130 additions & 0 deletions
130
metadata-utils/src/main/java/com/linkedin/metadata/utils/elasticsearch/FilterUtils.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| package com.linkedin.metadata.utils.elasticsearch; | ||
|
|
||
| import com.google.common.collect.ImmutableList; | ||
| import com.linkedin.data.template.StringArray; | ||
| import com.linkedin.metadata.query.filter.Condition; | ||
| import com.linkedin.metadata.query.filter.ConjunctiveCriterion; | ||
| import com.linkedin.metadata.query.filter.ConjunctiveCriterionArray; | ||
| import com.linkedin.metadata.query.filter.Criterion; | ||
| import com.linkedin.metadata.query.filter.CriterionArray; | ||
| import com.linkedin.metadata.query.filter.Filter; | ||
| import com.linkedin.metadata.utils.CriterionUtils; | ||
| import java.util.ArrayList; | ||
| import java.util.Collections; | ||
| import java.util.List; | ||
| import javax.annotation.Nonnull; | ||
| import javax.annotation.Nullable; | ||
|
|
||
| public class FilterUtils { | ||
|
|
||
| /** | ||
| * Combines two {@link Filter} instances in a conjunction and returns a new instance of {@link | ||
| * Filter} in disjunctive normal form. | ||
| * | ||
| * @param baseFilter the filter to apply the view to | ||
| * @param viewFilter the view filter, null if it doesn't exist | ||
| * @return a new instance of {@link Filter} representing the applied view. | ||
| */ | ||
| @Nonnull | ||
| public static Filter combineFilters( | ||
| @Nullable final Filter baseFilter, @Nonnull final Filter viewFilter) { | ||
| final Filter finalBaseFilter = | ||
| baseFilter == null | ||
| ? new Filter().setOr(new ConjunctiveCriterionArray(Collections.emptyList())) | ||
| : baseFilter; | ||
|
|
||
| // Join the filter conditions in Disjunctive Normal Form. | ||
| return combineFiltersInConjunction(finalBaseFilter, viewFilter); | ||
| } | ||
|
|
||
| /** | ||
| * Joins two filters in conjunction by reducing to Disjunctive Normal Form. | ||
| * | ||
| * @param filter1 the first filter in the pair | ||
| * @param filter2 the second filter in the pair | ||
| * <p>This method supports either Filter format, where the "or" field is used, instead of | ||
| * criteria. If the criteria filter is used, then it will be converted into an "OR" before | ||
| * returning the new filter. | ||
| * @return the result of joining the 2 filters in a conjunction (AND) | ||
| * <p>How does it work? It basically cross-products the conjunctions inside of each Filter | ||
| * clause. | ||
| * <p>Example Inputs: filter1 -> { or: [ { and: [ { field: tags, condition: EQUAL, values: | ||
| * ["urn:li:tag:tag"] } ] }, { and: [ { field: glossaryTerms, condition: EQUAL, values: | ||
| * ["urn:li:glossaryTerm:term"] } ] } ] } filter2 -> { or: [ { and: [ { field: domain, | ||
| * condition: EQUAL, values: ["urn:li:domain:domain"] }, ] }, { and: [ { field: glossaryTerms, | ||
| * condition: EQUAL, values: ["urn:li:glossaryTerm:term2"] } ] } ] } Example Output: { or: [ { | ||
| * and: [ { field: tags, condition: EQUAL, values: ["urn:li:tag:tag"] }, { field: domain, | ||
| * condition: EQUAL, values: ["urn:li:domain:domain"] } ] }, { and: [ { field: tags, | ||
| * condition: EQUAL, values: ["urn:li:tag:tag"] }, { field: glossaryTerms, condition: EQUAL, | ||
| * values: ["urn:li:glosaryTerm:term2"] } ] }, { and: [ { field: glossaryTerm, condition: | ||
| * EQUAL, values: ["urn:li:glossaryTerm:term"] }, { field: domain, condition: EQUAL, values: | ||
| * ["urn:li:domain:domain"] } ] }, { and: [ { field: glossaryTerm, condition: EQUAL, values: | ||
| * ["urn:li:glossaryTerm:term"] }, { field: glossaryTerms, condition: EQUAL, values: | ||
| * ["urn:li:glosaryTerm:term2"] } ] }, ] } | ||
| */ | ||
| @Nonnull | ||
| private static Filter combineFiltersInConjunction( | ||
| @Nonnull final Filter filter1, @Nonnull final Filter filter2) { | ||
|
|
||
| final Filter finalFilter1 = convertToV2Filter(filter1); | ||
| final Filter finalFilter2 = convertToV2Filter(filter2); | ||
|
|
||
| // If either filter is empty, simply return the other filter. | ||
| if (!finalFilter1.hasOr() || finalFilter1.getOr().size() == 0) { | ||
| return finalFilter2; | ||
| } | ||
| if (!finalFilter2.hasOr() || finalFilter2.getOr().size() == 0) { | ||
| return finalFilter1; | ||
| } | ||
|
|
||
| // Iterate through the base filter, then cross-product with filter 2 conditions. | ||
| final Filter result = new Filter(); | ||
| final List<ConjunctiveCriterion> newDisjunction = new ArrayList<>(); | ||
| for (ConjunctiveCriterion conjunction1 : finalFilter1.getOr()) { | ||
| for (ConjunctiveCriterion conjunction2 : finalFilter2.getOr()) { | ||
| final List<Criterion> joinedCriterion = new ArrayList<>(conjunction1.getAnd()); | ||
| joinedCriterion.addAll(conjunction2.getAnd()); | ||
| ConjunctiveCriterion newConjunction = | ||
| new ConjunctiveCriterion().setAnd(new CriterionArray(joinedCriterion)); | ||
| newDisjunction.add(newConjunction); | ||
| } | ||
| } | ||
| result.setOr(new ConjunctiveCriterionArray(newDisjunction)); | ||
| return result; | ||
| } | ||
|
|
||
| @Nonnull | ||
| private static Filter convertToV2Filter(@Nonnull Filter filter) { | ||
| if (filter.hasOr()) { | ||
| return filter; | ||
| } else if (filter.hasCriteria()) { | ||
| // Convert criteria to an OR | ||
| return new Filter() | ||
| .setOr( | ||
| new ConjunctiveCriterionArray( | ||
| ImmutableList.of(new ConjunctiveCriterion().setAnd(filter.getCriteria())))); | ||
| } | ||
| throw new IllegalArgumentException( | ||
| String.format( | ||
| "Illegal filter provided! Neither 'or' nor 'criteria' fields were populated for filter %s", | ||
| filter)); | ||
| } | ||
|
|
||
| @Nonnull | ||
| public static Filter createValuesFilter( | ||
| @Nonnull final String fieldName, @Nonnull final List<String> values) { | ||
| Filter filter = new Filter(); | ||
| CriterionArray criterionArray = new CriterionArray(); | ||
|
|
||
| StringArray valuesArray = new StringArray(); | ||
| valuesArray.addAll(values); | ||
| Criterion criterion = CriterionUtils.buildCriterion(fieldName, Condition.EQUAL, valuesArray); | ||
|
|
||
| criterionArray.add(criterion); | ||
| filter.setOr( | ||
| new ConjunctiveCriterionArray( | ||
| ImmutableList.of(new ConjunctiveCriterion().setAnd(criterionArray)))); | ||
|
|
||
| return filter; | ||
| } | ||
| } |
Oops, something went wrong.