Skip to content

Commit

Permalink
feat(searchBarAutocomplete): add feature flag for search bar's autoco…
Browse files Browse the repository at this point in the history
…mplete redesign (#12690)

Co-authored-by: Victor Tarasevich <v.tarasevitch@invento.by>
  • Loading branch information
v-tarasevich-blitz-brain and v-tarasevich authored Mar 5, 2025
1 parent 6998167 commit 256e488
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,8 @@ public CompletableFuture<AppConfig> get(final DataFetchingEnvironment environmen
.setShowNavBarRedesign(_featureFlags.isShowNavBarRedesign())
.setShowAutoCompleteResults(_featureFlags.isShowAutoCompleteResults())
.setEntityVersioningEnabled(_featureFlags.isEntityVersioning())
.setShowSearchBarAutocompleteRedesign(
_featureFlags.isShowSearchBarAutocompleteRedesign())
.build();

appConfig.setFeatureFlags(featureFlagsConfig);
Expand Down
5 changes: 5 additions & 0 deletions datahub-graphql-core/src/main/resources/app.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,11 @@ type FeatureFlagsConfig {
If turned on, exposes the versioning feature by allowing users to link entities in the UI.
"""
entityVersioningEnabled: Boolean!

"""
If turned on, show the redesigned search bar's autocomplete
"""
showSearchBarAutocompleteRedesign: Boolean!
}

"""
Expand Down
1 change: 1 addition & 0 deletions datahub-web-react/src/appConfigContext.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ export const DEFAULT_APP_CONFIG = {
showNavBarRedesign: false,
showAutoCompleteResults: false,
entityVersioningEnabled: false,
showSearchBarAutocompleteRedesign: false,
},
chromeExtensionConfig: {
enabled: false,
Expand Down
1 change: 1 addition & 0 deletions datahub-web-react/src/graphql/app.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ query appConfig {
showNavBarRedesign
showAutoCompleteResults
entityVersioningEnabled
showSearchBarAutocompleteRedesign
}
chromeExtensionConfig {
enabled
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,5 @@ public class FeatureFlags {
private boolean showAutoCompleteResults = false;
private boolean dataProcessInstanceEntityEnabled = true;
private boolean entityVersioning = false;
private boolean showSearchBarAutocompleteRedesign = false;
}
Original file line number Diff line number Diff line change
Expand Up @@ -503,6 +503,7 @@ featureFlags:
showNavBarRedesign: ${SHOW_NAV_BAR_REDESIGN:true} # If turned on, show the newly designed nav bar in the V2 experience
showAutoCompleteResults: ${SHOW_AUTO_COMPLETE_RESULTS:true} # If turned on, show the auto complete results in the search bar
entityVersioning: ${ENTITY_VERSIONING_ENABLED:false} # Enables entity versioning APIs, validators, and side effects
showSearchBarAutocompleteRedesign: ${SHOW_SEARCH_BAR_AUTOCOMPLETE_REDESIGN:false} # If turned on, show the redesigned search bar's autocomplete

entityChangeEvents:
enabled: ${ENABLE_ENTITY_CHANGE_EVENTS_HOOK:true}
Expand Down

0 comments on commit 256e488

Please sign in to comment.