Skip to content

Commit

Permalink
delete versionset and add sortid
Browse files Browse the repository at this point in the history
  • Loading branch information
yoonhyejin committed Mar 5, 2025
1 parent c0100cd commit 5d67288
Showing 1 changed file with 1 addition and 19 deletions.
20 changes: 1 addition & 19 deletions metadata-ingestion/src/datahub/ingestion/source/mlflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
TagPropertiesClass,
TimeStampClass,
VersionPropertiesClass,
VersionSetKeyClass,
VersionTagClass,
_Aspect,
)
Expand Down Expand Up @@ -498,7 +497,6 @@ def _get_ml_model_workunits(self) -> Iterable[MetadataWorkUnit]:
for registered_model in registered_models:
version_set_urn = self._get_version_set_urn(registered_model)
yield self._get_ml_group_workunit(registered_model)
yield self._get_version_set(version_set_urn)
model_versions = self._get_mlflow_model_versions(registered_model)
for model_version in model_versions:
run = self._get_mlflow_run(model_version)
Expand All @@ -521,22 +519,6 @@ def _get_version_set_urn(self, registered_model: RegisteredModel) -> VersionSetU

return version_set_urn

def _get_version_set(
self,
version_set_urn: VersionSetUrn,
) -> MetadataWorkUnit:
version_set_key = VersionSetKeyClass(
id=version_set_urn.id,
entityType="mlModel",
)

wu = MetadataChangeProposalWrapper(
entityUrn=str(version_set_urn),
aspect=version_set_key,
).as_workunit()

return wu

def _get_ml_model_version_properties_workunit(
self,
model_version: ModelVersion,
Expand All @@ -554,7 +536,7 @@ def _get_ml_model_version_properties_workunit(
),
),
versionSet=str(version_set_urn),
sortId="",
sortId=str(model_version.version).zfill(10),
aliases=[
VersionTagClass(versionTag=alias) for alias in model_version.aliases
],
Expand Down

0 comments on commit 5d67288

Please sign in to comment.