Skip to content

Commit

Permalink
Fix platform instance support on Druid ingestion (#12716)
Browse files Browse the repository at this point in the history
Co-authored-by: rasnar <11248833+Rasnar@users.noreply.github.com>
Co-authored-by: Sergio Gómez Villamor <sgomezvillamor@gmail.com>
  • Loading branch information
3 people authored Feb 26, 2025
1 parent f14c42d commit 5f5e395
Show file tree
Hide file tree
Showing 4 changed files with 81 additions and 77 deletions.
2 changes: 2 additions & 0 deletions docs/how/updating-datahub.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ This file documents any backwards-incompatible changes in DataHub and assists pe

- #12671: The `priority` field of the Incident entity is changed from an integer to an enum. This field was previously completely unused in UI and API, so this change should not affect existing deployments.

- #12716: Fix the `platform_instance` being added twice to the URN. If you want to have the previous behavior back, you need to add your platform_instance twice (i.e. `plat.plat`).


### Known Issues

Expand Down
6 changes: 1 addition & 5 deletions metadata-ingestion/src/datahub/ingestion/source/sql/druid.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,7 @@ def get_sql_alchemy_url(self):
"""

def get_identifier(self, schema: str, table: str) -> str:
return (
f"{self.platform_instance}.{table}"
if self.platform_instance
else f"{table}"
)
return f"{table}"


@platform_name("Druid")
Expand Down
Loading

0 comments on commit 5f5e395

Please sign in to comment.