fixed preset godlen to use original parameters

datahub-project · Mar 4, 2025 · 6b34552 · 6b34552
1 parent 2ba3410
commit 6b34552
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 13 deletions.
diff --git a/metadata-ingestion/tests/integration/preset/golden_test_ingest.json b/metadata-ingestion/tests/integration/preset/golden_test_ingest.json
@@ -14,7 +14,7 @@
                         "customProperties": {
                             "Status": "published",
                             "IsPublished": "true",
-                            "Owners": "test_owner1@example.com",
+                            "Owners": "test_owner1@example.com, test_owner2@example.com",
                             "IsCertified": "true",
                             "CertifiedBy": "Certification team",
                             "CertificationDetails": "Approved"
@@ -46,6 +46,10 @@
                             {
                                 "owner": "urn:li:corpuser:test_owner1@example.com",
                                 "type": "TECHNICAL_OWNER"
+                            },
+                            {
+                                "owner": "urn:li:corpuser:test_owner2@example.com",
+                                "type": "TECHNICAL_OWNER"
                             }
                         ],
                         "ownerTypes": {},

diff --git a/metadata-ingestion/tests/integration/preset/golden_test_stateful_ingest.json b/metadata-ingestion/tests/integration/preset/golden_test_stateful_ingest.json
@@ -14,7 +14,7 @@
                         "customProperties": {
                             "Status": "published",
                             "IsPublished": "true",
-                            "Owners": "test_owner4@example.com",
+                            "Owners": "test_owner1@example.com, test_owner2@example.com",
                             "IsCertified": "true",
                             "CertifiedBy": "Certification team",
                             "CertificationDetails": "Approved"
@@ -44,7 +44,11 @@
                     "com.linkedin.pegasus2avro.common.Ownership": {
                         "owners": [
                             {
-                                "owner": "urn:li:corpuser:test_owner4@example.com",
+                                "owner": "urn:li:corpuser:test_owner1@example.com",
+                                "type": "TECHNICAL_OWNER"
+                            },
+                            {
+                                "owner": "urn:li:corpuser:test_owner2@example.com",
                                 "type": "TECHNICAL_OWNER"
                             }
                         ],
@@ -60,7 +64,7 @@
     },
     "systemMetadata": {
         "lastObserved": 1720594800000,
-        "runId": "preset-2024_07_10-07_00_00-tzy8u0",
+        "runId": "preset-2024_07_10-07_00_00-xazuyh",
         "lastRunId": "no-run-id-provided",
         "pipelineName": "test_pipeline"
     }
@@ -118,7 +122,7 @@
     },
     "systemMetadata": {
         "lastObserved": 1720594800000,
-        "runId": "preset-2024_07_10-07_00_00-tzy8u0",
+        "runId": "preset-2024_07_10-07_00_00-xazuyh",
         "lastRunId": "no-run-id-provided",
         "pipelineName": "test_pipeline"
     }
@@ -176,7 +180,7 @@
     },
     "systemMetadata": {
         "lastObserved": 1720594800000,
-        "runId": "preset-2024_07_10-07_00_00-tzy8u0",
+        "runId": "preset-2024_07_10-07_00_00-xazuyh",
         "lastRunId": "no-run-id-provided",
         "pipelineName": "test_pipeline"
     }
@@ -234,7 +238,7 @@
     },
     "systemMetadata": {
         "lastObserved": 1720594800000,
-        "runId": "preset-2024_07_10-07_00_00-tzy8u0",
+        "runId": "preset-2024_07_10-07_00_00-xazuyh",
         "lastRunId": "no-run-id-provided",
         "pipelineName": "test_pipeline"
     }
@@ -292,7 +296,7 @@
     },
     "systemMetadata": {
         "lastObserved": 1720594800000,
-        "runId": "preset-2024_07_10-07_00_00-tzy8u0",
+        "runId": "preset-2024_07_10-07_00_00-xazuyh",
         "lastRunId": "no-run-id-provided",
         "pipelineName": "test_pipeline"
     }
@@ -309,7 +313,7 @@
     },
     "systemMetadata": {
         "lastObserved": 1720594800000,
-        "runId": "preset-2024_07_10-07_00_00-tzy8u0",
+        "runId": "preset-2024_07_10-07_00_00-xazuyh",
         "lastRunId": "no-run-id-provided",
         "pipelineName": "test_pipeline"
     }

diff --git a/metadata-ingestion/tests/integration/preset/test_preset.py b/metadata-ingestion/tests/integration/preset/test_preset.py
@@ -75,7 +75,12 @@ def register_mock_api(request_mock: Any, override_data: Optional[dict] = None) -
                                 "first_name": "Test",
                                 "id": 1,
                                 "last_name": "Owner1",
-                            }
+                            },
+                            {
+                                "first_name": "Test",
+                                "id": 2,
+                                "last_name": "Owner2",
+                            },
                         ],
                         "certified_by": "Certification team",
                         "certification_details": "Approved",
@@ -364,9 +369,14 @@ def test_preset_stateful_ingest(
                         "owners": [
                             {
                                 "first_name": "Test",
-                                "id": 4,
-                                "last_name": "Owners4",
-                            }
+                                "id": 1,
+                                "last_name": "Owners1",
+                            },
+                            {
+                                "first_name": "Test",
+                                "id": 2,
+                                "last_name": "Owners2",
+                            },
                         ],
                         "certified_by": "Certification team",
                         "certification_details": "Approved",