Skip to content

Commit

Permalink
Switch to luid project filter
Browse files Browse the repository at this point in the history
  • Loading branch information
mminichino committed Mar 5, 2025
1 parent 32b654c commit d077880
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1606,10 +1606,10 @@ def get_connection_objects(

def emit_workbooks(self) -> Iterable[MetadataWorkUnit]:
if self.tableau_project_registry:
project_names: List[str] = [
project.name for project in self.tableau_project_registry.values()
project_luids: List[str] = [

Check warning on line 1609 in metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py

View check run for this annotation

Codecov / codecov/patch

metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py#L1609

Added line #L1609 was not covered by tests
luid for luid in self.tableau_project_registry.keys()
]
projects = {c.PROJECT_NAME_WITH_IN: project_names}
projects = {c.PROJECT_LUID_WITH_IN: project_luids}

Check warning on line 1612 in metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py

View check run for this annotation

Codecov / codecov/patch

metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py#L1612

Added line #L1612 was not covered by tests

for workbook in self.get_connection_objects(
query=workbook_graphql_query,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
ERRORS = "errors"
NODES = "nodes"
PROJECT_NAME_WITH_IN = "projectNameWithin"
PROJECT_LUID_WITH_IN = "projectLuidWithin"
WORKBOOKS_CONNECTION = "workbooksConnection"
PROJECT_LUID = "projectLuid"
NAME = "name"
Expand Down

0 comments on commit d077880

Please sign in to comment.