Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contract): Show Dataset's Siblings Contract Information #11926

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(contract): Show Dataset's Siblings Contract Information #11926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c43f141
feat(contract): Show Dataset's Siblings Contract Information
matthew-coudert-cko Nov 22, 2024
c646c6b
Merge branch 'master' into master
matthew-coudert-cko Nov 26, 2024
793a2fa
Merge branch 'master' into master
hsheth2 Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions ...hub-web-react/src/app/entity/shared/tabs/Dataset/Validations/contract/DataContractTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { FreshnessContractSummary } from './FreshnessContractSummary';
import { DataContractBuilderModal } from './builder/DataContractBuilderModal';
import { createBuilderState } from './builder/utils';
import { getAssertionsSummary } from '../utils';
import {combineEntityDataWithSiblings, useIsSeparateSiblingsMode} from "../../../../siblingUtils";

const Container = styled.div`
display: flex;
Expand All @@ -35,12 +36,15 @@ export const DataContractTab = () => {
urn,
},
});
const isHideSiblingMode = useIsSeparateSiblingsMode();
const combinedData = isHideSiblingMode ? data : combineEntityDataWithSiblings(data);

const [showContractBuilder, setShowContractBuilder] = useState(false);

const contract = data?.dataset?.contract;
const schemaContracts = data?.dataset?.contract?.properties?.schema || [];
const freshnessContracts = data?.dataset?.contract?.properties?.freshness || [];
const dataQualityContracts = data?.dataset?.contract?.properties?.dataQuality || [];
const contract = combinedData?.dataset?.contract;
const schemaContracts = combinedData?.dataset?.contract?.properties?.schema || [];
const freshnessContracts = combinedData?.dataset?.contract?.properties?.freshness || [];
const dataQualityContracts = combinedData?.dataset?.contract?.properties?.dataQuality || [];
const schemaAssertions = schemaContracts.map((c) => c.assertion);
const freshnessAssertions = freshnessContracts.map((c) => c.assertion);
const dataQualityAssertions = dataQualityContracts.map((c) => c.assertion);
Expand All @@ -49,7 +53,7 @@ export const DataContractTab = () => {
...freshnessAssertions,
...dataQualityAssertions,
] as any);
const contractState = data?.dataset?.contract?.status?.state || DataContractState.Active;
const contractState = combinedData?.dataset?.contract?.status?.state || DataContractState.Active;
const hasFreshnessContract = freshnessContracts && freshnessContracts?.length;
const hasSchemaContract = schemaContracts && schemaContracts?.length;
const hasDataQualityContract = dataQualityContracts && dataQualityContracts?.length;
Expand All @@ -68,7 +72,7 @@ export const DataContractTab = () => {

return (
<>
{data?.dataset?.contract ? (
{combinedData?.dataset?.contract ? (
<>
<DataContractSummary
state={contractState}
Expand All @@ -79,15 +83,15 @@ export const DataContractTab = () => {
{showLeftColumn && (
<LeftColumn>
{(hasFreshnessContract && (
<FreshnessContractSummary
contracts={freshnessContracts as any}
showAction={false}
/>
)) ||
<FreshnessContractSummary
contracts={freshnessContracts as any}
showAction={false}
/>
)) ||
undefined}
{(hasSchemaContract && (
<SchemaContractSummary contracts={schemaContracts as any} showAction={false} />
)) ||
<SchemaContractSummary contracts={schemaContracts as any} showAction={false} />
)) ||
undefined}
</LeftColumn>
)}
Expand All @@ -114,4 +118,4 @@ export const DataContractTab = () => {
)}
</>
);
};
};
9 changes: 9 additions & 0 deletions datahub-web-react/src/graphql/contract.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,15 @@ query getDatasetContract($urn: String!) {
contract {
...dataContractDetails
}
siblings {
siblings {
...on Dataset {
contract {
...dataContractDetails
}
}
}
}
}
}

Expand Down
Loading