Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ingest): remove deprecated calls to Urn.create_from_string #11983

Merged
merged 4 commits into from
Dec 2, 2024
Merged

chore(ingest): remove deprecated calls to Urn.create_from_string #11983

merged 4 commits into from
Dec 2, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 27, 2024

Also does some light refactoring in the patch builders.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2
chore(ingest): remove deprecated calls to Urn.create_from_string
ceb8f5b 
Also does some light refactoring in the patch builders.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 27, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 27, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Dec 2, 2024
@hsheth2 hsheth2 merged commit ce6474d into master Dec 2, 2024
102 checks passed
@hsheth2 hsheth2 deleted the urn-create-deprecation branch December 2, 2024 17:53
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@hsheth2 @sleeperdeep
chore(ingest): remove deprecated calls to Urn.create_from_string (dat…
8c91df6 
…ahub-project#11983)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurinehate mayurinehate mayurinehate approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @mayurinehate