Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingestion) Adding vertexAI ingestion source (v1 - model group and model) #12632
base: master
Are you sure you want to change the base?
feat(ingestion) Adding vertexAI ingestion source (v1 - model group and model) #12632
Changes from 53 commits
45ce05e
9a1355d
04315d4
e3a17b5
2a5ea58
3739c20
520eda6
c320a6c
bc9e451
960129b
95712f5
78d184b
d746a4c
5fbe0e5
9f8e8a3
85d1830
aae6893
764f8fd
29ddcff
437e7d2
a2a1f0a
bf869da
c1f24b7
453688d
be03cf5
8c76435
33a19c9
b76ec25
c7d5165
482c159
1032630
616b76a
1dcfce1
f16c8f5
1de43a0
ea577cb
46ff526
9b6c01e
7b0fb70
cf9c242
398c380
4703cd9
63e8e8e
ba26abb
3a85d8a
84ebae0
0b6b7db
5472929
0eeeb72
6c43ecc
d381b9e
1f64a95
b559286
4edd575
5765025
4b09365
eb261c3
e6feb8a
a8d7980
b31d0f6
99269aa
a517173
f900f6d
5c46c59
1772b7e
8e40b7c
2a91e6d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be nested under list item 2 - not dedented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, probably big query doc also need to be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not fixed; this code block should be indented, similar to how the code blocks below are indented