Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingestion/s3): Add externalUrls for datasets in s3 and gcs #12678

Closed
wants to merge 6 commits into from
Closed

feat(ingestion/s3): Add externalUrls for datasets in s3 and gcs #12678

wants to merge 6 commits into from

Conversation

acrylJonny
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@acrylJonny acrylJonny marked this pull request as draft February 19, 2025 16:17
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Feb 19, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.52632% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ion/src/datahub/ingestion/source/gcs/gcs_source.py 58.33% 10 Missing ⚠️
...tion/src/datahub/ingestion/source/gcs/gcs_utils.py 16.66% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@acrylJonny acrylJonny closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@acrylJonny