Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(graphql): simplify getLastIngestionRun method #12706

Merged
merged 3 commits into from
Mar 7, 2025
Merged

refactor(graphql): simplify getLastIngestionRun method #12706

merged 3 commits into from
Mar 7, 2025

Conversation

trialiya
Copy link
Contributor

@trialiya trialiya commented Feb 21, 2025 •
edited
Loading

Optimized to improve performance by avoiding the creation and sorting of intermediate lists, using max to directly find the most recent run.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Feb 21, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 21, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trialiya trialiya force-pushed the feature/refactor-getLastIngestionRun branch from 8f6048c to bbc8b05 Compare February 22, 2025 17:32
@trialiya trialiya changed the title refactor: simplify getLastIngestionRun method refactor(graphql): simplify getLastIngestionRun method Feb 22, 2025
david-leifker
david-leifker approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@david-leifker david-leifker merged commit a51713a into datahub-project:master Mar 7, 2025
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trialiya @david-leifker