Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): add shared AutoCompleteResult component #12725

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

v-tarasevich-blitz-brain
Copy link
Contributor

image

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Feb 25, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 82 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...omponents/components/AutoComplete/AutoComplete.tsx 20.83% 38 Missing ⚠️
...hemy-components/components/MatchText/MatchText.tsx 21.42% 22 Missing ⚠️
...atahub-web-react/src/app/searchV2/SearchHeader.tsx 56.00% 11 Missing ⚠️
...-components/components/AutoComplete/components.tsx 75.00% 10 Missing ⚠️
datahub-web-react/src/app/searchV2/SearchBar.tsx 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
...lchemy-components/components/AutoComplete/index.ts 100.00% <100.00%> (ø)
...lchemy-components/components/MatchText/defaults.ts 100.00% <100.00%> (ø)
...c/alchemy-components/components/MatchText/index.ts 100.00% <100.00%> (ø)
...c/alchemy-components/components/MatchText/utils.ts 100.00% <100.00%> (ø)
datahub-web-react/src/alchemy-components/index.ts 100.00% <100.00%> (ø)
...atahub-web-react/src/app/previewV2/ContextPath.tsx 89.63% <100.00%> (+0.25%) ⬆️
datahub-web-react/src/app/searchV2/SearchBar.tsx 30.69% <50.00%> (ø)
...-components/components/AutoComplete/components.tsx 75.00% <75.00%> (ø)
...atahub-web-react/src/app/searchV2/SearchHeader.tsx 53.36% <56.00%> (-0.61%) ⬇️
...hemy-components/components/MatchText/MatchText.tsx 21.42% <21.42%> (ø)
... and 1 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ecd3bb...0f41170. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants