Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(graphql): implement sort and facet for scroll #12746

Merged
merged 1 commit into from
Feb 28, 2025
Merged

feat(graphql): implement sort and facet for scroll #12746

merged 1 commit into from
Feb 28, 2025

Conversation

david-leifker
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added docs Issues and Improvements to docs product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Feb 28, 2025
@david-leifker david-leifker changed the title feat(graphql): implement sort and fact for scroll feat(graphql): implement sort and facet for scroll Feb 28, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 28, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.41176% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../linkedin/metadata/search/EntitySearchService.java 0.00% 6 Missing ⚠️
...com/linkedin/entity/client/RestliEntityClient.java 0.00% 3 Missing ⚠️
...va/com/linkedin/metadata/search/SearchService.java 96.00% 0 Missing and 2 partials ⚠️
...data/search/client/CachingEntitySearchService.java 0.00% 1 Missing ⚠️
...enapi/operations/elastic/OperationsController.java 0.00% 1 Missing ⚠️
...service/util/SearchBasedFormAssignmentManager.java 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

esteban
esteban approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@esteban esteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Feb 28, 2025
@david-leifker david-leifker merged commit fe5d3b7 into datahub-project:master Feb 28, 2025
90 of 113 checks passed
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Mar 3, 2025
@david-leifker @shirshanka
feat(graphql): implement sort and facet for scroll (datahub-project#1…
3eb022b 
…2746)
PeteMango pushed a commit to PeteMango/datahub that referenced this pull request Mar 3, 2025
@david-leifker @PeteMango
feat(graphql): implement sort and facet for scroll (datahub-project#1…
7fd251c 
…2746)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esteban esteban esteban approved these changes

@RyanHolstien RyanHolstien RyanHolstien approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment docs Issues and Improvements to docs pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-leifker @esteban @RyanHolstien