revert(ci): revert datahub-wheel build changes #12747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #12722 and #12730 I attempted to make the cloudflare pages builds work on PRs from forks. It turns out cloudflare's pages-action had issues with PRs from forks, and we started seeing errors (e.g. https://github.com/datahub-project/datahub/actions/runs/13552436222/job/37879053347?pr=12732) when we tried an alternative action that used direct uploads. Maybe in the future we'll revisit this, but for now it's not worth the effort.
github-actions
bot
added
the
devops
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
datahub-cyborg
bot
added
the
needs-review
anshbansal
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #12722 and #12730 I attempted to make the cloudflare pages builds work on PRs from forks. It turns out cloudflare's pages-action had issues with PRs from forks, and we started seeing errors (e.g.
https://github.com/datahub-project/datahub/actions/runs/13552436222/job/37879053347?pr=12732) when we tried an alternative action that used direct uploads.
Maybe in the future we'll revisit this, but for now it's not worth the effort.
Checklist