Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compact lineage tab): do not use viewUrn as input for searchAcrossLineage graphql call #12748

Closed

Conversation

mattseddon
Copy link

@mattseddon mattseddon commented Feb 28, 2025

I was exploring https://demo.datahubproject.io/ and noticed that the compact lineage tab will not load when the "New User Experience" is enabled.

Example

Screen.Recording.2025-02-28.at.1.03.32.pm.mov

Note: this can easily be reproduced on the demo instance.

Upon further investigation, this only happens when the user uses a view. The error provided by the graphql endpoint is as follows: "The variables input contains a field name 'viewUrn' that is not defined for input object type 'SearchAcrossLineageInput' ".

I spent some time tracking down the correct way to fix the issue but it appears that the v2 operation does not use a viewUrn which makes sense to me (in terms of business logic). For this reason, I've excluded the problematic field from the <CompactLineageTab /> component's data query.

After Fix

Screen.Recording.2025-02-28.at.12.57.33.pm.mov

Please LMK if there are existing component/integration tests I can use as a template to test this fix.

Thanks,

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Feb 28, 2025
@mattseddon
Copy link
Author

cc @chriscollins3456, this was probably missed in #12481 but it was one of the first things I fell over on the demo site.

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 28, 2025
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...pp/entityV2/shared/tabs/Lineage/ImpactAnalysis.tsx 33.33% 2 Missing ⚠️
...entityV2/shared/tabs/Lineage/CompactLineageTab.tsx 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@chriscollins3456
Copy link
Collaborator

@mattseddon thank you so much for bringing this up here! i'm actually implementing a different fix which will support views for this API call which is the intended functionality. you can see that PR here: #12769

since we have the alternative approach in the above PR, I'm going to close this PR for now. thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants