Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/airflow): platform_instance support in Airflow plugin #12751

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(ingest/airflow): platform_instance support in Airflow plugin #12751

wants to merge 4 commits into from

Conversation

Rasnar
Copy link
Contributor

@Rasnar Rasnar commented Feb 28, 2025 •
edited
Loading

This adds support for Airflow platform_instance.
The browse path will be updated to also add the platform_instance on top of the normal dag_id name.

The changes to the format of log_url/external_url are not linked to my changes, but it's from the new format that is retrieve from the 1.25.0 openlineage plugin. Anyway, the link is perfectly working based on my tests in our environement (airflow 2.10.x).

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable) No link, just a new feature.
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata docs Issues and Improvements to docs community-contribution PR or Issue raised by member(s) of DataHub Community labels Feb 28, 2025
@Rasnar Rasnar changed the title platform_instance support in Airflow plugin feat(ingest/airflow): platform_instance support in Airflow plugin Feb 28, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...datahub_airflow_plugin/client/airflow_generator.py 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Rasnar Rasnar force-pushed the master branch 3 times, most recently from 551d08e to 62467b7 Compare February 28, 2025 18:27
@Rasnar Rasnar force-pushed the master branch 2 times, most recently from ae8a988 to 213706b Compare February 28, 2025 19:38
@Rasnar Rasnar marked this pull request as ready for review February 28, 2025 19:47
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Rasnar