Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(operations): ES and Kafka Operations Endpoints #12756

Merged
merged 2 commits into from
Mar 3, 2025
Merged

feat(operations): ES and Kafka Operations Endpoints #12756

merged 2 commits into from
Mar 3, 2025

Conversation

david-leifker
Copy link
Collaborator

@david-leifker david-leifker commented Mar 1, 2025 •
edited
Loading

Screenshot 2025-03-01 at 10 17 40 AM
Screenshot 2025-03-01 at 10 18 22 AM

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Mar 1, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Mar 1, 2025
@david-leifker david-leifker force-pushed the es-kafka-operations-endpoints branch from 0ec85bb to 11622e8 Compare March 1, 2025 18:03
@codecov Codecov
Copy link

codecov bot commented Mar 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.13311% with 67 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../com/linkedin/metadata/trace/KafkaTraceReader.java 70.83% 27 Missing and 8 partials ⚠️
...ject/openapi/operations/kafka/KafkaController.java 78.90% 17 Missing and 10 partials ⚠️
...pi/operations/elastic/ElasticsearchController.java 75.00% 2 Missing and 1 partial ⚠️
...tadata/search/elasticsearch/query/ESSearchDAO.java 91.66% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@david-leifker david-leifker force-pushed the es-kafka-operations-endpoints branch from 11622e8 to bbecaa1 Compare March 1, 2025 20:17
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Mar 3, 2025
@david-leifker
Copy link
Collaborator Author

metadata-io is not related

@david-leifker david-leifker merged commit 3dac08d into datahub-project:master Mar 3, 2025
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-leifker @RyanHolstien