Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingestion): fixes producing some URNs with reserved characters #12772

Merged
merged 8 commits into from
Mar 5, 2025
Merged

fix(ingestion): fixes producing some URNs with reserved characters #12772

merged 8 commits into from
Mar 5, 2025
+146 −23

Conversation

sgomezvillamor
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 4, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@sgomezvillamor sgomezvillamor marked this pull request as ready for review March 4, 2025 12:10
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Mar 4, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Mar 4, 2025
hsheth2
hsheth2 reviewed Mar 4, 2025
View reviewed changes
metadata-ingestion/tests/unit/sdk/test_mce_builder.py
@@ -8,6 +8,9 @@
MetadataChangeEventClass,
OwnershipClass,
)
from datahub.utilities.urn_encoder import RESERVED_CHARS_EXTENDED

_RESERVED_CHARS_STRING = "".join(sorted(list(RESERVED_CHARS_EXTENDED)))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can probably just be a hardcoded string. if the expected urns are hardcoded, this should be too.

ultimately as long as something is getting encoded, we know the encode_string call is happening and so we're fine on testing

@sgomezvillamor sgomezvillamor merged commit a0319af into master Mar 5, 2025
77 checks passed
@sgomezvillamor sgomezvillamor deleted the feature/cus-3452/fix-producing-urns-with-reserved-characters branch March 5, 2025 13:25
@PeteMango PeteMango mentioned this pull request Mar 6, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgomezvillamor @hsheth2