feat(okta): custom properties for okta user #12773
Merged
+301
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
datahub-cyborg
bot
added
the
needs-review
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
hsheth2
approved these changes
Mar 4, 2025
| @@ -671,6 +671,21 @@ def _map_okta_user_profile(self, profile: UserProfile) -> CorpUserInfoClass: | |||
| # TODO: Extract user's manager if provided. | |||
| # Source: https://developer.okta.com/docs/reference/api/users/#default-profile-properties | |||
| full_name = f"{profile.firstName} {profile.lastName}" | |||
| custom_properties = { | |||
| k: v | |||
| for k, v in profile.__dict__.items() | |||
There was a problem hiding this comment.
is this a safe thing to do? maybe we should also check that not k.startswith('_')?
There was a problem hiding this comment.
addressed in 79a201f
There was a problem hiding this comment.
about safety... well, it was safe for UserProfile
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
sgomezvillamor
deleted the
feature/cus-4006/feat-okta-user-cuustom-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist