Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): allowdenypattern for dashboard, chart, dataset in superset #12782

Conversation

kevinkarchacryl
Copy link
Contributor

Remaking this pull request from here. The rebase was getting unmanageable and I found it easier/less confusing to make a new PR.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@kevinkarchacryl kevinkarchacryl requested a review from hsheth2 March 4, 2025 21:30
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 63.88889% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ingestion/src/datahub/ingestion/source/superset.py 60.60% 13 Missing ⚠️

❌ Your patch status has failed because the patch coverage (63.88%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Mar 4, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Mar 4, 2025
@kevinkarchacryl kevinkarchacryl merged commit f327981 into datahub-project:master Mar 4, 2025
122 of 126 checks passed
@kevinkarchacryl kevinkarchacryl deleted the chart-dashboard-dataset-pattern-superset branch March 4, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants