Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(iceberg): iceberg doc updates #12787

Merged
merged 2 commits into from
Mar 6, 2025
Merged

doc(iceberg): iceberg doc updates #12787

merged 2 commits into from
Mar 6, 2025

Conversation

chakru-r
Copy link
Collaborator

@chakru-r chakru-r commented Mar 5, 2025

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@chakru-r chakru-r force-pushed the iceberg-doc-additions branch from a8f23fd to ff99030 Compare March 5, 2025 02:16
@github-actions github-actions bot added the docs Issues and Improvements to docs label Mar 5, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Mar 5, 2025
@chakru-r chakru-r force-pushed the iceberg-doc-additions branch from ff99030 to 50645d0 Compare March 5, 2025 07:11
shirshanka
shirshanka approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Mar 5, 2025
@shirshanka shirshanka merged commit 6d4744f into master Mar 6, 2025
55 checks passed
@shirshanka shirshanka deleted the iceberg-doc-additions branch March 6, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs merge-pending-ci A PR that has passed review and should be merged once CI is green. needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chakru-r @shirshanka