Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): humanize timestamps on ML entities UI #12788

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yoonhyejin
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Mar 5, 2025
@yoonhyejin yoonhyejin changed the title fix: humanize timestamps on ml UI fix(ui): humanize timestamps on ML entities UI Mar 5, 2025
@yoonhyejin yoonhyejin marked this pull request as ready for review March 5, 2025 06:42
@yoonhyejin yoonhyejin requested a review from asikowitz March 5, 2025 06:42
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Mar 5, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 54.65116% with 39 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ub-web-react/src/app/sharedV2/TimestampPopover.tsx 63.49% 23 Missing ⚠️
...p/entity/mlModelGroup/profile/ModelGroupModels.tsx 28.57% 5 Missing ⚠️
.../src/app/entity/mlModel/profile/MLModelSummary.tsx 25.00% 3 Missing ⚠️
...rc/app/entityV2/mlModel/profile/MLModelSummary.tsx 25.00% 3 Missing ⚠️
...entityV2/mlModelGroup/profile/ModelGroupModels.tsx 25.00% 3 Missing ⚠️
...essInstance/profile/DataProcessInstanceSummary.tsx 50.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (54.65%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant