Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes mypy complaints about pkgresources #12790

Merged
merged 4 commits into from
Mar 5, 2025

Conversation

sgomezvillamor
Copy link
Contributor

@sgomezvillamor sgomezvillamor commented Mar 5, 2025

From today we are pulling types-setuptools==75.8.2.20250305, and we are having this exception

tests/unit/test_packaging.py:11: error: Library stubs not installed for "pkg_resources"  [import-untyped]
tests/unit/test_packaging.py:11: note: Hint: "python3 -m pip install types-setuptools"
tests/unit/test_packaging.py:11: note: (or run "mypy --install-types" to install all missing stub packages)
tests/unit/test_packaging.py:11: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports

which matches with this PR from yesterday python/typeshed#13369

Stubs are not required since setuptools>=71.1.0

Note

Unfortunately only solved with the ignore mypy hint

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 5, 2025
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@sgomezvillamor sgomezvillamor changed the title fix: fixes mypy compliains about pkgresources fix: fixes mypy compliaints about pkgresources Mar 5, 2025
@sgomezvillamor sgomezvillamor changed the title fix: fixes mypy compliaints about pkgresources fix: fixes mypy complaints about pkgresources Mar 5, 2025
@sgomezvillamor sgomezvillamor marked this pull request as ready for review March 5, 2025 09:23
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Mar 5, 2025
@sgomezvillamor sgomezvillamor merged commit aed2433 into master Mar 5, 2025
102 of 106 checks passed
@sgomezvillamor sgomezvillamor deleted the fix-mypy-pkgresources branch March 5, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants