feat(ingest): improve extract-sql-agg-log command #12803
Merged
+98
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to extract all tables, instead of just the query log table. This lets us inspect the full internal state of the SqlParsingAggregator.
github-actions
bot
added
the
ingestion
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
datahub-cyborg
bot
added
the
needs-review
treff7es
approved these changes
Mar 6, 2025
| @@ -391,29 +395,78 @@ def test_path_spec(config: str, input: str, path_spec_key: str) -> None: | |||
| raise e | |||
|
|
|||
|
|
|||
| def _jsonify(data: Any) -> Any: | |||
| if dataclasses.is_dataclass(data): | |||
| # dataclasses.asdict() is recursive, which is not what we want. | |||
There was a problem hiding this comment.
Why don't we want dataclassess recursion if we do as well in recursion?
There was a problem hiding this comment.
updated the comment to clarify
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to extract all tables, instead of just the query log table. This lets us inspect the full internal state of the SqlParsingAggregator.
Checklist