Skip to content

Commit

Permalink
Add separator and better warning for taints in EKS nodepool definition (
Browse files Browse the repository at this point in the history
  • Loading branch information
vrutz authored Oct 2, 2024
1 parent 71185ce commit 550921c
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion parameter-sets/node-pool-request/parameter-set.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@
"defaultDefinableAtProjectLevel" : true,

"params": [
{
"type": "SEPARATOR",
"label": "Node pool definition",
"description": "<hr>"
},
{
"name": "nodeGroupId",
"label": "Node group ID",
Expand Down Expand Up @@ -101,7 +106,6 @@
{
"name": "taints",
"label": "Node taints",
"description": "WARNING: MUST CREATE AT LEAST ONE NODE POOL WITHOUT TAINTS. https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/",
"mandatory": false,
"type": "OBJECT_LIST",
"subParams": [
Expand Down Expand Up @@ -135,6 +139,11 @@
}
]
},
{
"type": "SEPARATOR",
"description": "<div class=\"alert alert-warning\"><i class=\"icon-dku-warning\"/><span>WARNING: MUST CREATE AT LEAST ONE NODE POOL WITHOUT TAINTS. <a href=\"https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/\">See documentation</a></span></div>",
"visibilityCondition": "model.taints && (model.taints.length > 0)"
},
{
"name": "enableGPU",
"label": "GPU",
Expand Down

0 comments on commit 550921c

Please sign in to comment.