Include dataiku font in minified assets.

dataiku · Jan 2, 2025 · 6315ed2 · 6315ed2
1 parent 007d847
commit 6315ed2
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 15 deletions.
diff --git a/dash_tabulator/assets/tabulator_dataiku.css b/dash_tabulator/assets/tabulator_dataiku.css
@@ -1,7 +1,6 @@
-/* define SourceSansPro */
 @font-face {
     font-family: 'dataiku';
-    src: url('/static/fonts/SourceSansPro-Regular.woff');
+    src: url('themes/default/assets/fonts/SourceSansPro-Regular.woff');
     font-weight: 400;
 }
 

diff --git a/...t/assets/fonts/SourceSansPro-Regular.woff → ...t/assets/fonts/SourceSansPro-Regular.woff b/...t/assets/fonts/SourceSansPro-Regular.woff → ...t/assets/fonts/SourceSansPro-Regular.woff
diff --git a/dss-plugin-visual-edit/python-lib/dash_tabulator/233217108bcf49dfd76a6588c37b4ca8.woff b/dss-plugin-visual-edit/python-lib/dash_tabulator/233217108bcf49dfd76a6588c37b4ca8.woff
diff --git a/dss-plugin-visual-edit/python-lib/dash_tabulator/446318d8eebe5dde9907dedef4928a23.ttf b/dss-plugin-visual-edit/python-lib/dash_tabulator/446318d8eebe5dde9907dedef4928a23.ttf
diff --git a/dss-plugin-visual-edit/python-lib/dash_tabulator/dash_tabulator.min.js b/dss-plugin-visual-edit/python-lib/dash_tabulator/dash_tabulator.min.js
diff --git a/dss-plugin-visual-edit/webapps/visual-edit/backend.py b/dss-plugin-visual-edit/webapps/visual-edit/backend.py
@@ -11,7 +11,6 @@
 # 3. Define Dash webapp layout and components.
 from __future__ import annotations
 import logging
-import os
 from webapp.config.models import LinkedRecord
 import webapp.logging.setup  # noqa: F401 necessary to setup logging basicconfig before dataiku module sets a default config
 from datetime import datetime
@@ -25,7 +24,7 @@
     EditUnauthorized,
     DataEditor,
 )
-from flask import Flask, jsonify, make_response, request, send_from_directory
+from flask import Flask, jsonify, make_response, request
 from tabulator_utils import get_columns_tabulator, get_values_from_df
 
 from webapp.config.loader import WebAppConfig
@@ -493,14 +492,4 @@ def lookup_endpoint(linked_ds_name):
     return jsonify(editor_values_param)
 
 
-FONTS_FOLDER = os.path.join(
-    os.path.dirname(os.path.abspath(__file__)), "assets", "fonts"
-)
-
-
-@server.route("/static/fonts/<path:filename>", methods=["GET"])
-def serve_fonts(filename):
-    return send_from_directory(FONTS_FOLDER, filename)
-
-
 logging.info("Webapp OK")