Add 'raw_allo_deployments' for use in downstream assets #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgasquez
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Nice!
Original ingestion logic is dependent on formatting of markdown document which feels very brittle thing to include, hence why I opted for the ipfs-fetch strategy.
What do you think about parsing hardcoded commits? E.g: 7c1b724d3a69835aae448757ddd943a3c53a6b5c.
Alternatively, we can parse the latest MD and fall back to the (latest IPFS_CID rawl_allo_deployments) IPFS snapshot (there might be dragons here as I can see ways this can go wrong).
That said, this works, and we can get it merged if you think the previous approach requires more work and is not worth it for the moment.
davidgasquez
reviewed
Jan 8, 2024
Co-authored-by: David Gasquez <davidgasquez@gmail.com>
|
I would rather merge this one in and focus on downstream uses for now. |
|
Perfect! 🚀 Merging it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new
static(based on pulling pre-processed '.parquet' from IPFS) asset with contract address for each official Allo contract.Main use of this data is feeding downstream
cryo/covalentassets, which should much more interesting.Original ingestion logic is dependent on formatting of markdown document which feels very brittle thing to include, hence why I opted for the
ipfs-fetchstrategy.catalogon the portal would not reflect new asset, but this isn't a priority to me for now.EDIT: Checked CI logs, looks ready to merge