Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented matching against filename and path #108

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

@dbr
Copy link
Owner

dbr commented Mar 29, 2015

Cool, thanks!

A few small things:

  1. A comment on filenames = [filename, fullname] etc would be good, as it was momentarily confusing why the code was like that (also, pedantically, the variables are a bit similar - filename, fullname, filenames, then filename is reused for the loop)
  2. Should it match against the filename before the full path? I would have thought the regexs for the full path should run first, since they are very unlikely to falsely match
  3. Could you add a couple of test cases (pretty much like the test_functional.py) - I guess the cases which should be tested are:
    • tvnamer /path/to/my show/season 1/03 - example.avi
    • tvnamer ./03 - example.avi (i.e does it run abspath on the path before parsing?)

Thoughts? I'm happy to make the changes if you don't have time

@m42e
Copy link
Author

m42e commented Mar 30, 2015

Hi,

I'm currently into it. Give me a few more days and I clean it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants