Revocation section update #56

rogulati · 2022-08-31T16:37:02Z

Update to revocation section

quartzjer · 2022-08-31T19:00:30Z

@rogulati Is this ready for review? Most of the json-tagged markdown sections contain invalid JSON yet :)

dwight-holman · 2022-09-01T18:25:06Z

Most of the included language and steps are also given in the referenced standards. The bits that aren't seem to be included in the examples, which are non-normative. If this was intended to address #22 , we need information about the message type and request headers (which are absent from the id-hub standard, but necessary to resolve revocation)

troyronda · 2022-09-01T20:39:43Z

spec/spec.md

-    "statusListIndex": "94567",
-    "statusListCredential": 'did:ion:123?service=IdentityHub&relativeRef=?messages=[{ type: "CollectionsQuery", statement: { id: "Qmdfr32sdf32546..." }}]'
+    "id": " https://example.com/credentials/status/3#234243",
+    "type": " RevocationList2021Status",


What is RevocationList2021Status? This doesn't appear in the referenced spec: https://w3c-ccg.github.io/vc-status-list-2021/

Underlying Status List 2021 spec was changed in this commit: w3c-ccg/vc-status-list-2021@a37a833

From RevocationList2021Status to StatusList2021Entry

this is the commit status list is pinned to: https://github.com/w3c-ccg/vc-status-list-2021/tree/343b8b59cddba4525e1ef355356ae760fc75904e

see issue #19

reasoning here why RevocationList2021Status: https://github.com/decentralized-identity/jwt-vc-presentation-profile/pull/56/files#r997429907

sudeshrshetty · 2022-09-01T21:07:55Z

spec/spec.md

+```json
+"credentialStatus": {	
+  "id": "Qmdfr32sdf32546...",
+  "type": "StatusList2021",


Shouldn't it be StatusList2021Entry according to https://w3c-ccg.github.io/vc-status-list-2021/#statuslist2021entry ?

I think we agreed to use this commit ver of StatusList2021 in v0.01 of this profile: https://github.com/w3c-ccg/vc-status-list-2021/tree/343b8b59cddba4525e1ef355356ae760fc75904e

so it should be RevocationList2021Status:
https://github.com/w3c-ccg/vc-status-list-2021/blob/343b8b59cddba4525e1ef355356ae760fc75904e/index.html#L252

when we move to final StatusList2021 in v1 of this profile, it will be StatusList2021Entry

Sakurann · 2022-10-17T19:21:28Z

spec/spec.md

+```json
+"credentialStatus": {	
+  "id": "Qmdfr32sdf32546...",
+  "type": "StatusList2021",


Suggested change

"type": "StatusList2021",

"type": "RevocationList2021Status",

Sakurann · 2022-10-17T21:32:42Z

spec/spec.md

-StatusList2021 MUST be used for revocation of VCs, as defined in [[ref: Status List 2021]].
-
-#### credentialStatus
+The profile utilizes [[ref: Status List 2021]] specification and outlines the status information of VCs as binary values.  


Suggested change

The profile utilizes [[ref: Status List 2021]] specification and outlines the status information of VCs as binary values.

The profile utilizes predraft version 0.0.1 of [[ref: Status List 2021]] specification and outlines the status information of VCs as binary values.

@rogulati Throughout the text and in the reference section, can you please update references to Status List 2021 to

[[def: Status List 2021 (0.01 Predraft)]]
~ Status List 2021 0.01 Predraft. Manu Sporny, Dave Longley, Orie Steele, Mike Prorock, Mahmoud Alkhraishi. 2022.01. Status: Draft Community Group Report v0.0.1.

Sakurann · 2022-10-17T21:59:28Z

spec/spec.md

-
-#### credentialStatus
+The profile utilizes [[ref: Status List 2021]] specification and outlines the status information of VCs as binary values.  
+When an issuer desires to enable status information for a verifiable credential, they MAY add a status property that uses the data model described in this specification. Credential status (credentialStatus) property in the Verifiable Credential provides the information on the current status of the credential. The issued VC may include a credentialStatus property, as defined in section 2.1 of [[ref: Status List 2021]]. An Issuer of a VC must use the HTTPS URL Structure or the DID Relative URLs stored in an ID Hub to host the status list as outlined in the specification. The issuer keeps a bitstring list of all verifiable credentials it has issued. Each verifiable credential is associated with a position in the list. If the binary value of the position in the list is 1 (one), the verifiable credential is revoked, if it is 0 (zero) it is not revoked.


Suggested change

When an issuer desires to enable status information for a verifiable credential, they MAY add a status property that uses the data model described in this specification. Credential status (credentialStatus) property in the Verifiable Credential provides the information on the current status of the credential. The issued VC may include a credentialStatus property, as defined in section 2.1 of [[ref: Status List 2021]]. An Issuer of a VC must use the HTTPS URL Structure or the DID Relative URLs stored in an ID Hub to host the status list as outlined in the specification. The issuer keeps a bitstring list of all verifiable credentials it has issued. Each verifiable credential is associated with a position in the list. If the binary value of the position in the list is 1 (one), the verifiable credential is revoked, if it is 0 (zero) it is not revoked.

To provide status information, the Issuer MUST add a status (credentialStatus) property to a W3C Verifiable Credential as defined in section 2.1 of [[ref: Status List 2021]]. An Issuer of a VC MUST use one of the following mechanisms to host the status list:

- the DID Relative URLs stored in an ID Hub

- the HTTPS URL structure

The issuer keeps a bitstring list of all verifiable credentials it has issued. Each verifiable credential is associated with a position in the list. If the binary value of the position in the list is 1 (one), the verifiable credential is revoked, if it is 0 (zero) it is not revoked.

Sakurann · 2022-10-17T22:00:31Z

spec/spec.md

+The profile utilizes [[ref: Status List 2021]] specification and outlines the status information of VCs as binary values.  
+When an issuer desires to enable status information for a verifiable credential, they MAY add a status property that uses the data model described in this specification. Credential status (credentialStatus) property in the Verifiable Credential provides the information on the current status of the credential. The issued VC may include a credentialStatus property, as defined in section 2.1 of [[ref: Status List 2021]]. An Issuer of a VC must use the HTTPS URL Structure or the DID Relative URLs stored in an ID Hub to host the status list as outlined in the specification. The issuer keeps a bitstring list of all verifiable credentials it has issued. Each verifiable credential is associated with a position in the list. If the binary value of the position in the list is 1 (one), the verifiable credential is revoked, if it is 0 (zero) it is not revoked.
+
+#### DID-Relative URL Structure


Suggested change

#### DID-Relative URL Structure

#### Hosting a Status List in a the DID Relative URLs stored in an ID Hub

Sakurann · 2022-10-17T22:01:17Z

spec/spec.md

 ```

+#### HTTPS URL Structure


Suggested change

#### HTTPS URL Structure

#### Hosting a Status List using an HTTPS URL structure

Sakurann · 2022-10-17T22:02:00Z

spec/spec.md

-
-#### credentialStatus
+The profile utilizes [[ref: Status List 2021]] specification and outlines the status information of VCs as binary values.  
+When an issuer desires to enable status information for a verifiable credential, they MAY add a status property that uses the data model described in this specification. Credential status (credentialStatus) property in the Verifiable Credential provides the information on the current status of the credential. The issued VC may include a credentialStatus property, as defined in section 2.1 of [[ref: Status List 2021]]. An Issuer of a VC must use the HTTPS URL Structure or the DID Relative URLs stored in an ID Hub to host the status list as outlined in the specification. The issuer keeps a bitstring list of all verifiable credentials it has issued. Each verifiable credential is associated with a position in the list. If the binary value of the position in the list is 1 (one), the verifiable credential is revoked, if it is 0 (zero) it is not revoked.


what is an HTTPS URL Structure? should it be HTTPS URL?

Sakurann · 2022-10-17T22:05:05Z

spec/spec.md

+The profile utilizes [[ref: Status List 2021]] specification and outlines the status information of VCs as binary values.  
+When an issuer desires to enable status information for a verifiable credential, they MAY add a status property that uses the data model described in this specification. Credential status (credentialStatus) property in the Verifiable Credential provides the information on the current status of the credential. The issued VC may include a credentialStatus property, as defined in section 2.1 of [[ref: Status List 2021]]. An Issuer of a VC must use the HTTPS URL Structure or the DID Relative URLs stored in an ID Hub to host the status list as outlined in the specification. The issuer keeps a bitstring list of all verifiable credentials it has issued. Each verifiable credential is associated with a position in the list. If the binary value of the position in the list is 1 (one), the verifiable credential is revoked, if it is 0 (zero) it is not revoked.
+
+#### DID-Relative URL Structure


looking at DID-Core spec, looks like the convention is to say relative DID URL as opposed to DID-Relative URL. suggest to make a replacement throughout the PR text.

Sakurann · 2022-10-17T22:06:45Z

spec/spec.md

+
+#### DID-Relative URL Structure
+An Issuer of a VC may have an “IdentityHub” node serviceEndpoint in the Issuer's DID Document. Identity Hub nodes are the single endpoint to look up objects associated with a DID, as defined in [[def: Identity Hub (0.0.1 Predraft)]] (Decentralized Web Node v0.0.1 predraft)). 
+The following process defines how a DID-Relative URL is composed:


Is there a source for this process? if yes, suggest referencing it, if not, this should be super useful.

Sakurann · 2022-10-17T22:08:06Z

spec/spec.md

+
+#### DID-Relative URL Structure
+An Issuer of a VC may have an “IdentityHub” node serviceEndpoint in the Issuer's DID Document. Identity Hub nodes are the single endpoint to look up objects associated with a DID, as defined in [[def: Identity Hub (0.0.1 Predraft)]] (Decentralized Web Node v0.0.1 predraft)). 
+The following process defines how a DID-Relative URL is composed:


Suggested change

The following process defines how a DID-Relative URL is composed:

##### Constructing a Relative DID URL

The following process defines how a DID-Relative URL is composed:

Sakurann · 2022-10-17T22:10:03Z

spec/spec.md

+4.	JSON stringify the array of Message Descriptor objects from Step 3, then Base64Url encode the stringified output.
+5.	Append a queries parameter to the DID URL string with the value set to the JSON stringified, Base64Url encoded output of Step 4.
+
+##### DID-relative URLs are composed of the following segments


Suggested change

##### DID-relative URLs are composed of the following segments

I think it's pretty natural to show a code to construct a relative DID URL following steps defined above without a new section

Sakurann · 2022-10-17T22:11:19Z

spec/spec.md

+```json
+did:example:123 + ?service=IdentityHub + &queries= + toBase64Url( JSON.stringify( [{ DESCRIPTOR_1 }, { DESCRIPTOR_N }] ) )
+did:example:123?service=IdentityHub&queries=W3sgTUVTU0FHRV8xIH0sIHsgTUVTU0FHRV9OIH1d..
+```


Suggested change

```json

did:example:123 + ?service=IdentityHub + &queries= + toBase64Url( JSON.stringify( [{ DESCRIPTOR_1 }, { DESCRIPTOR_N }] ) )

did:example:123?service=IdentityHub&queries=W3sgTUVTU0FHRV8xIH0sIHsgTUVTU0FHRV9OIH1d..

```

```json

did:example:123 + ?service=IdentityHub + &queries= + toBase64Url( JSON.stringify( [{ DESCRIPTOR_1 }, { DESCRIPTOR_N }] ) )

Revocation section update

bf58e45

Update to revocation section

rogulati requested review from bumblefudge, paulgrehan, ChrisKellyLP, dtmcg, quartzjer, Sakurann and jischr as code owners August 31, 2022 16:37

troyronda reviewed Sep 1, 2022

View reviewed changes

sudeshrshetty reviewed Sep 1, 2022

View reviewed changes

jischr added the not-ready label Sep 21, 2022

Sakurann reviewed Oct 17, 2022

View reviewed changes

MissAlleyCat approved these changes Dec 16, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revocation section update #56

Revocation section update #56

rogulati commented Aug 31, 2022

quartzjer commented Aug 31, 2022

dwight-holman commented Sep 1, 2022

troyronda Sep 1, 2022

troyronda Sep 2, 2022

Sakurann Sep 7, 2022

Sakurann Sep 7, 2022

Sakurann Oct 17, 2022

sudeshrshetty Sep 1, 2022 •

edited

Loading

Sakurann Oct 17, 2022

Sakurann Oct 17, 2022 •

edited

Loading

Sakurann Oct 17, 2022

Sakurann Oct 17, 2022

Sakurann Oct 17, 2022 •

edited

Loading

Sakurann Oct 17, 2022

Sakurann Oct 17, 2022

Sakurann Oct 17, 2022

Sakurann Oct 17, 2022

Sakurann Oct 17, 2022

Sakurann Oct 17, 2022

Sakurann Oct 17, 2022

Sakurann Oct 17, 2022

Sakurann Oct 17, 2022

	"type": "StatusList2021",
	"type": "RevocationList2021Status",

	The profile utilizes [[ref: Status List 2021]] specification and outlines the status information of VCs as binary values.
	The profile utilizes predraft version 0.0.1 of [[ref: Status List 2021]] specification and outlines the status information of VCs as binary values.

	#### DID-Relative URL Structure
	#### Hosting a Status List in a the DID Relative URLs stored in an ID Hub

	#### HTTPS URL Structure
	#### Hosting a Status List using an HTTPS URL structure

Revocation section update #56

Are you sure you want to change the base?

Revocation section update #56

Conversation

rogulati commented Aug 31, 2022

quartzjer commented Aug 31, 2022

dwight-holman commented Sep 1, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sudeshrshetty Sep 1, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sakurann Oct 17, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sakurann Oct 17, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sudeshrshetty Sep 1, 2022 •

edited

Loading

Sakurann Oct 17, 2022 •

edited

Loading

Sakurann Oct 17, 2022 •

edited

Loading