updated workflow #96
Open
updated workflow #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andorsk
requested review from
bumblefudge,
paulgrehan,
dtmcg,
quartzjer,
Sakurann and
jischr
as code owners
bumblefudge
reviewed
Jun 21, 2023
| @@ -18,8 +18,7 @@ jobs: | |||
| - name: Install and Build 🔧 # This example project is built using npm and outputs the result to the 'build' folder. Replace with the commands required to build your project, or remove this step entirely if your site is pre-built. | |||
| run: | | |||
| npm install | |||
| node -e "require('./index')({ nowatch: true })" | |||
| rm -rf node_modules | |||
| npm run build | |||
There was a problem hiding this comment.
Suggested change
| npm run build | |
| npm run render |
Sakurann
approved these changes
Aug 2, 2023
|
might be worth updating the original template.... |
dwaite
requested changes
Aug 2, 2023
There was a problem hiding this comment.
I think I'd prefer this change first made to the upstream template (https://github.com/decentralized-identity/template-for-profile-workitems/blob/main/.github/workflows/render-specs.yml), rather than having each project maintain changes to actions individually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.