Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vm): set disk serial by uid resource #710

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Conversation

yaroslavborbat
Copy link
Member

@yaroslavborbat yaroslavborbat commented Feb 6, 2025

Description

Disk serials are now generated using the MD5 hash of the disk uid instead of the disk name itself. This prevents errors caused by recent QEMU changes enforcing a strict 36-character limit on serial numbers.

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm  
type: fix  
summary: disk serials are now generated using the MD5 hash of the disk uid instead of the disk name itself; this prevents errors caused by recent QEMU changes enforcing a strict 36-character limit on serial numbers

@yaroslavborbat yaroslavborbat changed the title fix(vm) set disk serial by uid resource fix(vm): set disk serial by uid resource Feb 6, 2025
@yaroslavborbat yaroslavborbat added this to the v0.15.1 milestone Feb 6, 2025
Isteb4k
Isteb4k previously approved these changes Feb 7, 2025
@yaroslavborbat yaroslavborbat force-pushed the fix/disk-serial-by-uid branch 2 times, most recently from 369b587 to 0e913ae Compare February 10, 2025 08:01
@fl64 fl64 modified the milestones: v0.15.1, v0.16.0 Feb 10, 2025
Isteb4k
Isteb4k previously approved these changes Feb 10, 2025
@Isteb4k Isteb4k self-requested a review February 10, 2025 13:14
@Isteb4k Isteb4k marked this pull request as draft February 10, 2025 13:14
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
@yaroslavborbat yaroslavborbat marked this pull request as ready for review February 10, 2025 14:02
Isteb4k
Isteb4k previously approved these changes Feb 10, 2025
@Isteb4k Isteb4k self-requested a review February 10, 2025 14:12
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
@yaroslavborbat yaroslavborbat merged commit 8e5b050 into main Feb 10, 2025
14 checks passed
@yaroslavborbat yaroslavborbat deleted the fix/disk-serial-by-uid branch February 10, 2025 16:28
This was referenced Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants